[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20231205.110618.1499275558053658998.fujita.tomonori@gmail.com>
Date: Tue, 05 Dec 2023 11:06:18 +0900 (JST)
From: FUJITA Tomonori <fujita.tomonori@...il.com>
To: jarkko@...nel.org
Cc: fujita.tomonori@...il.com, netdev@...r.kernel.org,
rust-for-linux@...r.kernel.org, andrew@...n.ch, tmgross@...ch.edu,
miguel.ojeda.sandonis@...il.com, benno.lossin@...ton.me,
wedsonaf@...il.com, aliceryhl@...gle.com, boqun.feng@...il.com
Subject: Re: [PATCH net-next v9 1/4] rust: core abstractions for network
PHY drivers
On Tue, 05 Dec 2023 03:43:50 +0200
"Jarkko Sakkinen" <jarkko@...nel.org> wrote:
> On Tue Dec 5, 2023 at 3:14 AM EET, FUJITA Tomonori wrote:
>> This patch adds abstractions to implement network PHY drivers; the
>> driver registration and bindings for some of callback functions in
>> struct phy_driver and many genphy_ functions.
>>
>> This feature is enabled with CONFIG_RUST_PHYLIB_ABSTRACTIONS=y.
>
> Just a question: is `_ABSTRACTIONS` a convention or just for this
> config flag?
It's a convention.
https://docs.kernel.org/rust/general-information.html#abstractions-vs-bindings
> That would read anyway that this rust absraction of phy absraction
> layer or similar.
>
> Why not e.g.
>
> - `CONFIG_RUST_PHYLIB_BINDINGS`
> - `CONFIG_RUST_PHYLIB_API`
> - Or even just `CONFIG_RUST_PHYLIB`?
I guess that CONFIG_RUST_PHYLIB_API or CONFIG_RUST_PHYLIB could be
used. CONFIG_RUST_PHYLIB_ABSTRACTIONS was preferred during the past
reviewing.
Powered by blists - more mailing lists