netdev - Re: [PATCH v4 bpf-next 3/3] selftest: bpf: Test bpf_sk_assign_tcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231205030056.96419-1-kuniyu@amazon.com>
Date: Tue, 5 Dec 2023 12:00:56 +0900
From: Kuniyuki Iwashima <kuniyu@...zon.com>
To: <alexei.starovoitov@...il.com>
CC: <andrii@...nel.org>, <ast@...nel.org>, <bpf@...r.kernel.org>,
	<daniel@...earbox.net>, <edumazet@...gle.com>, <kuni1840@...il.com>,
	<kuniyu@...zon.com>, <martin.lau@...ux.dev>, <netdev@...r.kernel.org>
Subject: Re: [PATCH v4 bpf-next 3/3] selftest: bpf: Test bpf_sk_assign_tcp_reqsk().

From: Alexei Starovoitov <alexei.starovoitov@...il.com>
Date: Mon, 4 Dec 2023 18:13:55 -0800
> On Mon, Dec 4, 2023 at 5:36 PM Kuniyuki Iwashima <kuniyu@...zon.com> wrote:
> >
> > +static __always_inline int tcp_load_headers(struct tcp_syncookie *ctx)
> 
> ...
> 
> > +static __always_inline int tcp_reload_headers(struct tcp_syncookie *ctx)
> 
> please remove __always_inline here and in all other places.
> The generated code will be much better == faster and the verifier
> should be able to understand it.

I confirmed the test worked without __always_inline.
I'll fix it in v5.

Thanks!