netdev - Re: [PATCH bpf-next v4 06/10] libbpf: selftests: Add verifier tests for CO-RE bitfield writes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 4 Dec 2023 20:05:27 -0800
From: Andrii Nakryiko <andrii.nakryiko@...il.com>
To: Daniel Xu <dxu@...uu.xyz>
Cc: daniel@...earbox.net, shuah@...nel.org, andrii@...nel.org, ast@...nel.org, 
	steffen.klassert@...unet.com, antony.antony@...unet.com, 
	alexei.starovoitov@...il.com, yonghong.song@...ux.dev, eddyz87@...il.com, 
	mykolal@...com, martin.lau@...ux.dev, song@...nel.org, 
	john.fastabend@...il.com, kpsingh@...nel.org, sdf@...gle.com, 
	haoluo@...gle.com, jolsa@...nel.org, linux-kernel@...r.kernel.org, 
	bpf@...r.kernel.org, linux-kselftest@...r.kernel.org, devel@...ux-ipsec.org, 
	netdev@...r.kernel.org
Subject: Re: [PATCH bpf-next v4 06/10] libbpf: selftests: Add verifier tests
 for CO-RE bitfield writes

On Mon, Dec 4, 2023 at 12:57 PM Daniel Xu <dxu@...uu.xyz> wrote:
>
> Add some tests that exercise BPF_CORE_WRITE_BITFIELD() macro. Since some
> non-trivial bit fiddling is going on, make sure various edge cases (such
> as adjacent bitfields and bitfields at the edge of structs) are
> exercised.
>
> Acked-by: Andrii Nakryiko <andrii@...nel.org>
> Signed-off-by: Daniel Xu <dxu@...uu.xyz>
> ---

nit: please drop "libbpf: " prefix from the patch subject, this is
"selftests/bpf: " actually


>  .../selftests/bpf/prog_tests/verifier.c       |   2 +
>  .../bpf/progs/verifier_bitfield_write.c       | 100 ++++++++++++++++++
>  2 files changed, 102 insertions(+)
>  create mode 100644 tools/testing/selftests/bpf/progs/verifier_bitfield_write.c
>

[...]