[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202312051347.L3L2pNLv-lkp@intel.com>
Date: Tue, 5 Dec 2023 13:53:09 +0800
From: kernel test robot <lkp@...el.com>
To: Sneh Shah <quic_snehshah@...cinc.com>, Vinod Koul <vkoul@...nel.org>,
Bhupesh Sharma <bhupesh.sharma@...aro.org>,
Alexandre Torgue <alexandre.torgue@...s.st.com>,
Jose Abreu <joabreu@...opsys.com>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Maxime Coquelin <mcoquelin.stm32@...il.com>,
linux-arm-msm@...r.kernel.org,
linux-stm32@...md-mailman.stormreply.com,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, netdev@...r.kernel.org,
Sneh Shah <quic_snehshah@...cinc.com>, kernel@...cinc.com,
Andrew Halaney <ahalaney@...hat.com>
Subject: Re: [PATCH net-next] net: stmmac: qcom-ethqos: Add sysfs nodes for
qcom ethqos
Hi Sneh,
kernel test robot noticed the following build warnings:
[auto build test WARNING on net-next/main]
url: https://github.com/intel-lab-lkp/linux/commits/Sneh-Shah/net-stmmac-qcom-ethqos-Add-sysfs-nodes-for-qcom-ethqos/20231204-165232
base: net-next/main
patch link: https://lore.kernel.org/r/20231204084854.31543-1-quic_snehshah%40quicinc.com
patch subject: [PATCH net-next] net: stmmac: qcom-ethqos: Add sysfs nodes for qcom ethqos
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20231205/202312051347.L3L2pNLv-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231205/202312051347.L3L2pNLv-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312051347.L3L2pNLv-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c: In function 'gvm_queue_mapping_store':
>> drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c:770:13: warning: variable 'prio' set but not used [-Wunused-but-set-variable]
770 | u32 prio;
| ^~~~
vim +/prio +770 drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c
762
763 static ssize_t gvm_queue_mapping_store(struct device *dev,
764 struct device_attribute *attr,
765 const char *user_buf, size_t size)
766 {
767 struct net_device *netdev = to_net_dev(dev);
768 struct stmmac_priv *priv;
769 struct qcom_ethqos *ethqos;
> 770 u32 prio;
771 s8 input = 0;
772
773 if (!netdev) {
774 pr_err("netdev is NULL\n");
775 return -EINVAL;
776 }
777
778 priv = netdev_priv(netdev);
779 if (!priv) {
780 pr_err("priv is NULL\n");
781 return -EINVAL;
782 }
783
784 ethqos = priv->plat->bsp_priv;
785 if (!ethqos) {
786 pr_err("ethqos is NULL\n");
787 return -EINVAL;
788 }
789
790 if (kstrtos8(user_buf, 0, &input)) {
791 pr_err("Error in reading option from user\n");
792 return -EINVAL;
793 }
794
795 if (input == ethqos->gvm_queue)
796 pr_err("No effect as duplicate input\n");
797
798 ethqos->gvm_queue = input;
799 prio = 1 << input;
800
801 return size;
802 }
803
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists