netdev - Re: [PATCH for-next v5 7/7] RDMA/rxe: Add module parameters for mcast limits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <95f41a77-e283-4e86-82e1-4a46c9dfeb30@linux.dev>
Date: Tue, 5 Dec 2023 13:58:23 +0800
From: Zhu Yanjun <yanjun.zhu@...ux.dev>
To: Bob Pearson <rpearsonhpe@...il.com>, jgg@...dia.com,
 linux-rdma@...r.kernel.org, dsahern@...nel.org, davem@...emloft.net,
 netdev@...r.kernel.org
Subject: Re: [PATCH for-next v5 7/7] RDMA/rxe: Add module parameters for mcast
 limits

Add  David S. Miller and  David Ahern.

They are the maintainers in netdev and very familiar with mcast.

Zhu Yanjun

在 2023/12/5 8:26, Bob Pearson 写道:
> Add module parameters for max_mcast_grp, max_mcast_qp_attach,
> and tot_mcast_qp_attach to allow setting these parameters to
> small values when the driver is loaded to support testing these
> limits.
>
> Signed-off-by: Bob Pearson <rpearsonhpe@...il.com>
> ---
>   drivers/infiniband/sw/rxe/Makefile    |  3 ++-
>   drivers/infiniband/sw/rxe/rxe.c       |  6 +++---
>   drivers/infiniband/sw/rxe/rxe_param.c | 23 +++++++++++++++++++++++
>   drivers/infiniband/sw/rxe/rxe_param.h |  4 ++++
>   4 files changed, 32 insertions(+), 4 deletions(-)
>   create mode 100644 drivers/infiniband/sw/rxe/rxe_param.c
>
> diff --git a/drivers/infiniband/sw/rxe/Makefile b/drivers/infiniband/sw/rxe/Makefile
> index 5395a581f4bb..b183924ea01d 100644
> --- a/drivers/infiniband/sw/rxe/Makefile
> +++ b/drivers/infiniband/sw/rxe/Makefile
> @@ -22,4 +22,5 @@ rdma_rxe-y := \
>   	rxe_mcast.o \
>   	rxe_task.o \
>   	rxe_net.o \
> -	rxe_hw_counters.o
> +	rxe_hw_counters.o \
> +	rxe_param.o
> diff --git a/drivers/infiniband/sw/rxe/rxe.c b/drivers/infiniband/sw/rxe/rxe.c
> index 147cb16e937d..599fbfdeb426 100644
> --- a/drivers/infiniband/sw/rxe/rxe.c
> +++ b/drivers/infiniband/sw/rxe/rxe.c
> @@ -59,9 +59,9 @@ static void rxe_init_device_param(struct rxe_dev *rxe)
>   	rxe->attr.max_res_rd_atom		= RXE_MAX_RES_RD_ATOM;
>   	rxe->attr.max_qp_init_rd_atom		= RXE_MAX_QP_INIT_RD_ATOM;
>   	rxe->attr.atomic_cap			= IB_ATOMIC_HCA;
> -	rxe->attr.max_mcast_grp			= RXE_MAX_MCAST_GRP;
> -	rxe->attr.max_mcast_qp_attach		= RXE_MAX_MCAST_QP_ATTACH;
> -	rxe->attr.max_total_mcast_qp_attach	= RXE_MAX_TOT_MCAST_QP_ATTACH;
> +	rxe->attr.max_mcast_grp			= rxe_max_mcast_grp;
> +	rxe->attr.max_mcast_qp_attach		= rxe_max_mcast_qp_attach;
> +	rxe->attr.max_total_mcast_qp_attach	= rxe_max_tot_mcast_qp_attach;
>   	rxe->attr.max_ah			= RXE_MAX_AH;
>   	rxe->attr.max_srq			= RXE_MAX_SRQ;
>   	rxe->attr.max_srq_wr			= RXE_MAX_SRQ_WR;
> diff --git a/drivers/infiniband/sw/rxe/rxe_param.c b/drivers/infiniband/sw/rxe/rxe_param.c
> new file mode 100644
> index 000000000000..27873e7de753
> --- /dev/null
> +++ b/drivers/infiniband/sw/rxe/rxe_param.c
> @@ -0,0 +1,23 @@
> +// SPDX-License-Identifier: GPL-2.0 OR Linux-OpenIB
> +/*
> + * Copyright (c) 2023 Hewlett Packard Enterprise, Inc. All rights reserved.
> + */
> +
> +#include "rxe.h"
> +
> +int rxe_max_mcast_grp = RXE_MAX_MCAST_GRP;
> +module_param_named(max_mcast_grp, rxe_max_mcast_grp, int, 0444);
> +MODULE_PARM_DESC(max_mcast_grp,
> +	"Maximum number of multicast groups per device");
> +
> +int rxe_max_mcast_qp_attach = RXE_MAX_MCAST_QP_ATTACH;
> +module_param_named(max_mcast_qp_attach, rxe_max_mcast_qp_attach,
> +		int, 0444);
> +MODULE_PARM_DESC(max_mcast_qp_attach,
> +	"Maximum number of QPs attached to a multicast group");
> +
> +int rxe_max_tot_mcast_qp_attach = RXE_MAX_TOT_MCAST_QP_ATTACH;
> +module_param_named(max_tot_mcast_qp_attach, rxe_max_tot_mcast_qp_attach,
> +		int, 0444);
> +MODULE_PARM_DESC(max_tot_mcast_qp_attach,
> +	"Maximum total number of QPs attached to multicast groups per device");
> diff --git a/drivers/infiniband/sw/rxe/rxe_param.h b/drivers/infiniband/sw/rxe/rxe_param.h
> index d2f57ead78ad..d6fe50f5f483 100644
> --- a/drivers/infiniband/sw/rxe/rxe_param.h
> +++ b/drivers/infiniband/sw/rxe/rxe_param.h
> @@ -125,6 +125,10 @@ enum rxe_device_param {
>   	RXE_VENDOR_ID			= 0XFFFFFF,
>   };
>   
> +extern int rxe_max_mcast_grp;
> +extern int rxe_max_mcast_qp_attach;
> +extern int rxe_max_tot_mcast_qp_attach;
> +
>   /* default/initial rxe port parameters */
>   enum rxe_port_param {
>   	RXE_PORT_GID_TBL_LEN		= 1024,