netdev - RE: [PATCH net] net: libwx: fix memory leak on free page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <04f201da275c$566735d0$0335a170$@trustnetic.com>
Date: Tue, 5 Dec 2023 17:20:49 +0800
From: Jiawen Wu <jiawenwu@...stnetic.com>
To: "'duanqiangwen'" <duanqiangwen@...-swift.com>,
	<netdev@...r.kernel.org>,
	<kuba@...nel.org>,
	<mengyuanlou@...-swift.com>,
	<davem@...emloft.net>,
	<pabeni@...hat.com>,
	<yang.lee@...ux.alibaba.com>,
	<error27@...il.com>,
	<horms@...nel.org>
Subject: RE: [PATCH net] net: libwx: fix memory leak on free page

> @@ -2248,8 +2180,7 @@ static void wx_clean_rx_ring(struct wx_ring *rx_ring)
> 
>  		/* free resources associated with mapping */
>  		page_pool_put_full_page(rx_ring->page_pool, rx_buffer->page, false);
> -		__page_frag_cache_drain(rx_buffer->page,
> -					rx_buffer->pagecnt_bias);
> +

No need to add this blank line. Other looks good to me, thanks!

Reviewed-by: Jiawen Wu <jiawenwu@...stnetic.com>

> 
>  		i++;
>  		rx_buffer++;