netdev - Re: [RFC PATCH] net: ethtool: do runtime PM outside RTNL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <69c0fa67c2b0930f72e99c19c72fc706627989af.camel@sipsolutions.net>
Date: Mon, 04 Dec 2023 22:32:25 +0100
From: Johannes Berg <johannes@...solutions.net>
To: Marc MERLIN <marc@...lins.org>
Cc: netdev@...r.kernel.org, Jesse Brandeburg <jesse.brandeburg@...el.com>, 
 Tony Nguyen <anthony.l.nguyen@...el.com>, intel-wired-lan@...ts.osuosl.org,
 Heiner Kallweit <hkallweit1@...il.com>, Jakub Kicinski <kuba@...nel.org>
Subject: Re: [RFC PATCH] net: ethtool: do runtime PM outside RTNL

On Mon, 2023-12-04 at 13:28 -0800, Marc MERLIN wrote:
> 
> Where do you we go from here? Is the patch obviously good/safe, or do we
> need to narrow things down/test some more?
> 

Well, I was hoping that

 (a) ethtool folks / Jakub would comment if this makes sense, but I
     don't see a good reason to do things the other way around (other
     than "code is simpler"); and

 (b) Intel wired folks could help out with getting the patch across the
     finish line, seeing how their driver needs it :) I think the dev
     get/put needs to use the newer API, but I didn't immediately see
     how that works locally in a function without an allocated tracker

johannes