netdev - Re: [PATCH AUTOSEL 4.14] wifi: cfg80211: lock wiphy mutex for rfkill poll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <71d0f8424661b0d7b2c371e422416854790e477a.camel@sipsolutions.net>
Date: Mon, 04 Dec 2023 21:50:29 +0100
From: Johannes Berg <johannes@...solutions.net>
To: Sasha Levin <sashal@...nel.org>, linux-kernel@...r.kernel.org, 
	stable@...r.kernel.org
Cc: syzbot+7e59a5bfc7a897247e18@...kaller.appspotmail.com, 
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com,  linux-wireless@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 4.14] wifi: cfg80211: lock wiphy mutex for
 rfkill poll

On Mon, 2023-12-04 at 15:37 -0500, Sasha Levin wrote:
> 
> +++ b/net/wireless/core.c
> @@ -202,7 +202,9 @@ static void cfg80211_rfkill_poll(struct rfkill *rfkill, void *data)
>  {
>  	struct cfg80211_registered_device *rdev = data;
>  
> +	wiphy_lock(&rdev->wiphy);

This can't even _build_ on this old kernel?!

Anyway, my locking rework only went into 6.7, so this doesn't make sense
in any stable kernel, it's just not required.

johannes