[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20231205165540.jnmzuh4pb5xayode@skbuf>
Date: Tue, 5 Dec 2023 18:55:40 +0200
From: Vladimir Oltean <olteanv@...il.com>
To: Daniel Danzberger <dd@...edd.com>
Cc: woojung.huh@...rochip.com, UNGLinuxDriver@...rochip.com,
netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>,
Florian Fainelli <f.fainelli@...il.com>
Subject: Re: [PATCH] net: dsa: microchip: fix NULL pointer dereference on
platform init
On Tue, Dec 05, 2023 at 09:00:39AM +0100, Daniel Danzberger wrote:
> > Is this all that's necessary for instantiating the ksz driver through
> > ds->dev->platform_data? I suppose not, so can you post it all, please?
> Yes, that NULL pointer was the only issue I encountered.
I was just thinking, the KSZ9477 has internal PHYs on ports 0-4, and an
internal MDIO bus registered in ksz_mdio_register(). The bus registration
won't work without OF, since it returns early when not finding
of_get_child_by_name(dev->dev->of_node, "mdio").
Don't you need the internal PHY ports to work?
Powered by blists - more mailing lists