netdev - Re: [PATCH iwl-next 1/2] ice: Refactor FW data type and fix bitmap casting issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 5 Dec 2023 19:16:02 +0000
From: Simon Horman <horms@...nel.org>
To: Steven Zou <steven.zou@...el.com>
Cc: intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
	przemyslaw.kitszel@...el.com, andriy.shevchenko@...ux.intel.com,
	aleksander.lobakin@...el.com, andrii.staikov@...el.com,
	jan.sokolowski@...el.com
Subject: Re: [PATCH iwl-next 1/2] ice: Refactor FW data type and fix bitmap
 casting issue

On Fri, Dec 01, 2023 at 02:25:01PM +0800, Steven Zou wrote:
> According to the datasheet, the recipe association data is an 8-byte
> little-endian value. It is described as 'Bitmap of the recipe indexes
> associated with this profile', it is from 24 to 31 byte area in FW.
> Therefore, it is defined to '__le64 recipe_assoc' in struct
> ice_aqc_recipe_to_profile. And then fix the bitmap casting issue, as we
> must never ever use castings for bitmap type.
> 
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> Reviewed-by: Andrii Staikov <andrii.staikov@...el.com>
> Reviewed-by: Jan Sokolowski <jan.sokolowski@...el.com>
> Signed-off-by: Steven Zou <steven.zou@...el.com>

Reviewed-by: Simon Horman <horms@...nel.org>