netdev - Re: [net-next PATCH v3 3/3] net: phy: add support for PHY package MMD read/write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <91dcd8c3-ae86-4350-838d-62ddb62fa2bb@quicinc.com>
Date: Tue, 5 Dec 2023 11:58:14 -0800
From: Jeff Johnson <quic_jjohnson@...cinc.com>
To: "Russell King (Oracle)" <linux@...linux.org.uk>
CC: Jakub Kicinski <kuba@...nel.org>, Andrew Lunn <andrew@...n.ch>,
        Christian
 Marangi <ansuelsmth@...il.com>,
        Florian Fainelli
	<florian.fainelli@...adcom.com>,
        Broadcom internal kernel review list
	<bcm-kernel-feedback-list@...adcom.com>,
        Heiner Kallweit
	<hkallweit1@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet
	<edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
        David Epping
	<david.epping@...singlinkelectronics.com>,
        Vladimir Oltean
	<olteanv@...il.com>,
        Harini Katakam <harini.katakam@....com>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <workflows@...r.kernel.org>
Subject: Re: [net-next PATCH v3 3/3] net: phy: add support for PHY package MMD
 read/write

On 12/5/2023 10:14 AM, Russell King (Oracle) wrote:
> On Tue, Dec 05, 2023 at 09:44:05AM -0800, Jeff Johnson wrote:
>> So in my experience a function prototype IS the function definition, and
>> the actual function is just the implementation of that definition.
>>
>> But that thinking obviously isn't shared by others.
> 
> Interestingly, the view that a function prototype is a function
> definition does not seem to be shared by w3school, Microsoft, IBM,
> and many more.
> 
> If we look at the C99 standard, then 6.9.1 Function definitions gives
> the syntax as including a compound-statement, which is defined as
> requiring the curley braces and contents. Therefore, a function
> definition as defined by the C standard includes its body.
> 

Note I was speaking in terms of functional languages in general, not C
specifically. Perhaps I should have used the term "specification"
instead of "definition" (which would align with the Ada terminology).

Having worked with closed-source systems, especially VxWorks, for many
years (where the header files contain all the documentation), it just
seems strange to embed the documentation in the .c files.

/jeff