netdev - Re: [PATCH v5 2/3] NFSD: convert write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231205203312.GV50400@kernel.org>
Date: Tue, 5 Dec 2023 20:33:12 +0000
From: Simon Horman <horms@...nel.org>
To: Lorenzo Bianconi <lorenzo@...nel.org>
Cc: linux-nfs@...r.kernel.org, lorenzo.bianconi@...hat.com, neilb@...e.de,
	netdev@...r.kernel.org, jlayton@...nel.org, kuba@...nel.org
Subject: Re: [PATCH v5 2/3] NFSD: convert write_version to netlink command

On Wed, Nov 29, 2023 at 06:12:44PM +0100, Lorenzo Bianconi wrote:
> Introduce write_version netlink command similar to the ones available
> through the procfs.
> 
> Signed-off-by: Lorenzo Bianconi <lorenzo@...nel.org>

...

> +/**
> + * nfsd_nl_version_get_doit - Handle verion_get dumpit

Hi Lorenzo,

a minor nit: this function is nfsd_nl_version_get_dumpit

> + * @skb: reply buffer
> + * @cb: netlink metadata and command arguments
> + *
> + * Returns the size of the reply or a negative errno.
> + */
> +int nfsd_nl_version_get_dumpit(struct sk_buff *skb,

...