netdev - Re: [PATCH net v2 3/3] r8152: Choose our USB config with choose

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231204182740.62a49a14@kernel.org>
Date: Mon, 4 Dec 2023 18:27:40 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Douglas Anderson <dianders@...omium.org>
Cc: linux-usb@...r.kernel.org, Greg Kroah-Hartman
 <gregkh@...uxfoundation.org>, "David S . Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Grant
 Grundler <grundler@...omium.org>, Hayes Wang <hayeswang@...ltek.com>, Simon
 Horman <horms@...nel.org>, Bjørn Mork <bjorn@...k.no>,
 netdev@...r.kernel.org, Brian Geffon <bgeffon@...gle.com>, Alan Stern
 <stern@...land.harvard.edu>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net v2 3/3] r8152: Choose our USB config with
 choose_configuration() rather than probe()

On Fri,  1 Dec 2023 10:29:52 -0800 Douglas Anderson wrote:
> If you deauthorize the r8152 device (by writing 0 to the "authorized"
> field in sysfs) and then reauthorize it (by writing a 1) then it no
> longer works. This is because when you do the above we lose the
> special configuration that we set in rtl8152_cfgselector_probe().
> Deauthorizing causes the config to be set to -1 and then reauthorizing
> runs the default logic for choosing the best config.
> 
> I made an attempt to fix it so that the config is kept across
> deauthorizing / reauthorizing [1] but it was a bit ugly.
> 
> Let's instead use the new USB core feature to override
> choose_configuration().
> 
> This patch relies upon the patches ("usb: core: Don't force USB
> generic_subclass drivers to define probe()") and ("usb: core: Allow
> subclassed USB drivers to override usb_choose_configuration()")

Acked-by: Jakub Kicinski <kuba@...nel.org>