netdev - Re: [PATCH net-next v5] netlink: specs: devlink: add some(not all) missing attributes in devlink.yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZXAoGhUnBFzQxD0f@nanopsycho>
Date: Wed, 6 Dec 2023 08:51:54 +0100
From: Jiri Pirko <jiri@...nulli.us>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Swarup Laxman Kotiaklapudi <swarupkotikalapudi@...il.com>,
	davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
	netdev@...r.kernel.org,
	linux-kernel-mentees@...ts.linuxfoundation.org
Subject: Re: [PATCH net-next v5] netlink: specs: devlink: add some(not all)
 missing attributes in devlink.yaml

Wed, Dec 06, 2023 at 04:19:44AM CET, kuba@...nel.org wrote:
>On Sat,  2 Dec 2023 18:00:48 +0530 Swarup Laxman Kotiaklapudi wrote:
>> Add some missing(not all) attributes in devlink.yaml.
>
>Hi Jiri,
>
>Do you want to take a closer look at the spec here?
>Looks fine to me, on a quick scroll.

Yep, will do that later today.

>
>> Suggested-by: Jiri Pirko <jiri@...nulli.us>
>> Suggested-by: Jakub Kicinski <kuba@...nel.org>
>> Fixes: f2f9dd164db0 ("netlink: specs: devlink: add the remaining command to generate complete split_ops")
>
>I'll drop these when / if applying, FWIW. 
>
>Swarup, for future reference if there are comments / changes suggested
>during normal review process you don't have to add the Suggested-by

My "suggested-by" is probably fine as I suggested Swarup to make the patch :)


>tag. The expectation is that the reviewer will send a Reviewed-by tag
>themselves at the end instead.