netdev - Re: [PATCH net-next v3 8/9] net: rswitch: Add jumbo frames handling for TX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 06 Dec 2023 11:21:08 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>, s.shtylyov@....ru,
  davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org
Cc: netdev@...r.kernel.org, linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH net-next v3 8/9] net: rswitch: Add jumbo frames handling
 for TX

On Mon, 2023-12-04 at 10:20 +0900, Yoshihiro Shimoda wrote:
> @@ -1647,25 +1676,32 @@ static netdev_tx_t rswitch_start_xmit(struct sk_buff *skb, struct net_device *nd
>  	if (skb_put_padto(skb, ETH_ZLEN))
>  		return ret;
>  
> -	dma_addr = dma_map_single(ndev->dev.parent, skb->data, skb->len, DMA_TO_DEVICE);
> -	if (dma_mapping_error(ndev->dev.parent, dma_addr))
> +	dma_addr_orig = dma_map_single(ndev->dev.parent, skb->data, skb->len, DMA_TO_DEVICE);
> +	if (dma_mapping_error(ndev->dev.parent, dma_addr_orig))
>  		goto err_kfree;
>  
>  	gq->skbs[gq->cur] = skb;
>  	gq->unmap_addrs[gq->cur] = dma_addr;

Here 'dma_addr' is still used uninitialized. I guess you should use
'dma_addr_orig' even here.

Cheers,

Paolo