[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <89b68781-b552-499d-a8f2-df4dccbb02e0@tuxon.dev>
Date: Wed, 6 Dec 2023 13:48:26 +0200
From: claudiu beznea <claudiu.beznea@...on.dev>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: s.shtylyov@....ru, davem@...emloft.net, edumazet@...gle.com,
kuba@...nel.org, pabeni@...hat.com, robh+dt@...nel.org,
krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
linux@...linux.org.uk, magnus.damm@...il.com, mturquette@...libre.com,
sboyd@...nel.org, linus.walleij@...aro.org, p.zabel@...gutronix.de,
arnd@...db.de, m.szyprowski@...sung.com, alexandre.torgue@...s.st.com,
afd@...com, broonie@...nel.org, alexander.stein@...tq-group.com,
eugen.hristev@...labora.com, sergei.shtylyov@...il.com,
prabhakar.mahadev-lad.rj@...renesas.com, biju.das.jz@...renesas.com,
linux-renesas-soc@...r.kernel.org, netdev@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-clk@...r.kernel.org,
linux-gpio@...r.kernel.org, Claudiu Beznea <claudiu.beznea.uj@...renesas.com>
Subject: Re: [PATCH 13/14] arm64: dts: renesas: rzg3s-smarc-som: Enable
Ethernet interfaces
Hi, Geert,
On 06.12.2023 13:22, Geert Uytterhoeven wrote:
> Hi Claudiu,
>
> Thanks for your patch!
>
> On Mon, Nov 20, 2023 at 8:03 AM Claudiu <claudiu.beznea@...on.dev> wrote:
>> From: Claudiu Beznea <claudiu.beznea.uj@...renesas.com>
>>
>> RZ/G3S Smarc Module has Ethernet PHYs (KSZ9131) connected to each Ethernet
>> IP. For this add proper DT bindings to enable the Ethernet communication
>> though these PHYs.
>>
>> The interface b/w PHYs and MACs is RGMII. The skew settings were set to
>> zero as based on phy-mode (rgmii-id) the KSZ9131 driver enables internal
>> DLL which adds 2ns delay b/w clocks (TX/RX) and data signals.
>
> So shouldn't you just use phy-mode "rgmii" instead?
I chose it like this for simpler configuration of the skew settings. The
PHY supports fixed 2ns delays which is enough for RGMII. And this is
configured based on phy-mode="rgmii-id". As this delay depends also on
soldering length I consider it better this way.
The other variant would have been using phy-mode="rgmii" + skew settings.
Also, same phy-mode is used by rzg2ul-smarc-som.dtsi which is using the
same PHY.
>> Different pin settings were applied to TXC, TX_CTL compared with the rest
>> of the RGMII pins to comply with requirements for these pins imposed by
>> HW manual of RZ/G3S (see chapters "Ether Ch0 Voltage Mode Control
>> Register (ETH0_POC)", "Ether Ch1 Voltage Mode Control Register (ETH1_POC)",
>> for power source selection, "Ether MII/RGMII Mode Control Register
>> (ETH_MODE)" for output-enable and "Input Enable Control Register (IEN_m)"
>> for input-enable configurations).
>>
>> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@...renesas.com>
>
>> --- a/arch/arm64/boot/dts/renesas/rzg3s-smarc-som.dtsi
>> +++ b/arch/arm64/boot/dts/renesas/rzg3s-smarc-som.dtsi
>> @@ -25,7 +25,10 @@ / {
>>
>> aliases {
>> mmc0 = &sdhi0;
>> -#if !SW_SD2_EN
>> +#if SW_SD2_EN
>
> Cfr. my comment on [PATCH 11/14], this looks odd...
>
>> + eth0 = ð0;
>> + eth1 = ð1;
>> +#else
>> mmc2 = &sdhi2;
>> #endif
>> };
>> @@ -81,6 +84,64 @@ vcc_sdhi2: regulator2 {
>> };
>> };
>>
>> +#if SW_SD2_EN
>
> Likewise.
>
>> +ð0 {
>> + pinctrl-0 = <ð0_pins>;
>> + pinctrl-names = "default";
>> + phy-handle = <&phy0>;
>> + phy-mode = "rgmii-id";
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>
> #{address,size}-cells should be in the SoC-specific .dtsi.
> Same for eth1.
>
>> + status = "okay";
>
> The rest LGTM.
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Powered by blists - more mailing lists