netdev - Re: [PATCH v2] leds: trigger: netdev: fix RTNL handling to prevent potential deadlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231206133234.GD3375667@google.com>
Date: Wed, 6 Dec 2023 13:32:34 +0000
From: Lee Jones <lee@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Pavel Machek <pavel@....cz>, Heiner Kallweit <hkallweit1@...il.com>,
	Christian Marangi <ansuelsmth@...il.com>,
	Andrew Lunn <andrew@...n.ch>,
	"linux-leds@...r.kernel.org" <linux-leds@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Simon Horman <horms@...nel.org>
Subject: Re: [PATCH v2] leds: trigger: netdev: fix RTNL handling to prevent
 potential deadlock

On Mon, 04 Dec 2023, Jakub Kicinski wrote:

> On Fri, 1 Dec 2023 11:23:22 +0100 Heiner Kallweit wrote:
> > When working on LED support for r8169 I got the following lockdep
> > warning. Easiest way to prevent this scenario seems to be to take
> > the RTNL lock before the trigger_data lock in set_device_name().
> 
> Pavel/Lee, would you like to handle this patch?
> Or should we ship it to Linus on Thu?

Go for it.

Acked-by: Lee Jones <lee@...nel.org>

-- 
Lee Jones [李琼斯]