netdev - Re: [PATCH net-next v2 3/3] net: sched: Add initial TC error skb drop reasons

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <69d540ad-c855-49bc-a904-824e57e33adc@mojatatu.com>
Date: Tue, 5 Dec 2023 20:19:11 -0300
From: Victor Nogueira <victor@...atatu.com>
To: Dave Taht <dave.taht@...il.com>
Cc: jhs@...atatu.com, xiyou.wangcong@...il.com, jiri@...nulli.us,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, daniel@...earbox.net, dcaratti@...hat.com,
 netdev@...r.kernel.org, kernel@...atatu.com
Subject: Re: [PATCH net-next v2 3/3] net: sched: Add initial TC error skb drop
 reasons

On 05/12/2023 19:28, Dave Taht wrote:
> On Fri, Dec 1, 2023 at 6:00 PM Victor Nogueira <victor@...atatu.com> wrote:
>>
>> Continue expanding Daniel's patch by adding new skb drop reasons that
>> are idiosyncratic to TC.
>>
>> More specifically:
>>
>> - SKB_DROP_REASON_TC_EXT_COOKIE_NOTFOUND: tc cookie was looked up using
>>    ext, but was not found.
>>
>> - SKB_DROP_REASON_TC_COOKIE_EXT_MISMATCH: tc ext was looked up using cookie
>>    and either was not found or different from expected.
>>
>> - SKB_DROP_REASON_TC_CHAIN_NOTFOUND: tc chain lookup failed.
>>
>> - SKB_DROP_REASON_TC_RECLASSIFY_LOOP: tc exceeded max reclassify loop
>>    iterations
>>
>> Signed-off-by: Victor Nogueira <victor@...atatu.com>
>> ---
>>
>> [...]
> 
> I have been meaning to get around to adding
> QDISC_DROP_REASON_{CONGEST,OVERFLOW,FLOOD,SPIKE} to
> cake/fq_codel/red/etc for some time now. Would this be the right
> facility to leverage (or something more direct?) I discussed the why
> at netdevconf:

> 
> https://docs.google.com/document/d/1tTYBPeaRdCO9AGTGQCpoiuLORQzN_bG3TAkEolJPh28/edit

Yes, I think here will be the place to add these new drop reasons.
After this patch lands, we will add more, but feel free to also
propose others.

cheers,
Victor