lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CADEbmW3bn7btX_8RiOEncyh+M+WMK5Kxi+Gy_o3P2pi3u7rzHg@mail.gmail.com>
Date: Wed, 6 Dec 2023 14:55:40 +0100
From: Michal Schmidt <mschmidt@...hat.com>
To: Shinas Rasheed <srasheed@...vell.com>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, hgani@...vell.com, 
	vimleshk@...vell.com, egallen@...hat.com, pabeni@...hat.com, horms@...nel.org, 
	kuba@...nel.org, davem@...emloft.net, wizhao@...hat.com, konguyen@...hat.com, 
	Veerasenareddy Burru <vburru@...vell.com>, Sathesh Edara <sedara@...vell.com>, 
	Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH net v3] octeon_ep: initialise control mbox tasks before
 using APIs

On Wed, Dec 6, 2023 at 2:52 PM Shinas Rasheed <srasheed@...vell.com> wrote:
>
> Initialise various workqueue tasks and queue interrupt poll task
> before the first invocation of any control net APIs. Since
> octep_ctrl_net_get_info was called before the control net receive
> work task was initialised or even the interrupt poll task was
> queued, the function call wasn't returning actual firmware
> info queried from Octeon.
>
> Fixes: 8d6198a14e2b ("octeon_ep: support to fetch firmware info")
> Signed-off-by: Shinas Rasheed <srasheed@...vell.com>
> ---
> V3:
>   - Included Fixes line in commit log.
>   - Corrected typo in print statement.
>
> V2: https://lore.kernel.org/all/20231205130625.2586755-1-srasheed@marvell.com/
>   - Updated changelog.
>   - Handled error return for octep_ctrl_net_get_info
>
> V1: https://lore.kernel.org/all/20231202150807.2571103-1-srasheed@marvell.com/
>
>  .../ethernet/marvell/octeon_ep/octep_main.c   | 22 +++++++++++--------
>  1 file changed, 13 insertions(+), 9 deletions(-)

Good timing. I was just going to write to you about the typo :)
Looks good now.

Reviewed-by: Michal Schmidt <mschmidt@...hat.com>


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ