[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <f7588e40-0fea-4350-89fe-c432eacb68f7@huawei.com>
Date: Wed, 6 Dec 2023 20:31:43 +0800
From: Jijie Shao <shaojijie@...wei.com>
To: Paolo Abeni <pabeni@...hat.com>, <yisen.zhuang@...wei.com>,
<salil.mehta@...wei.com>, <davem@...emloft.net>, <edumazet@...gle.com>,
<kuba@...nel.org>, <wojciech.drewek@...el.com>
CC: <shaojijie@...wei.com>, <shenjian15@...wei.com>, <wangjie125@...wei.com>,
<liuyonglong@...wei.com>, <netdev@...r.kernel.org>,
<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V3 net 1/2] net: hns: fix wrong head when modify the tx
feature when sending packets
on 2023/12/6 19:18, Paolo Abeni wrote:
> + priv->ops.fill_desc = fill_desc_v2;
> + priv->ops.maybe_stop_tx = hns_nic_maybe_stop_tx_v2;
> Side note: since both 'fill_desc' and 'maybe_stop_tx' have constant
> values, for net-next you should really consider replacing the function
> pointers with direct-calls.
>
> You currently have at least 2 indirect calls per wire packet, which
> hurt performances a lot in case security issues mitigations are in
> place.
>
> Cheers,
>
> Paolo
Thank you for your advice. Currently, because the hardware behavior is
different, the two versions of ops are retained to unify the subsequent
process. We will try to unify the two version ops, and if that does not
work, we will consider maintaining the status quo. Thanks again! Jijie
Powered by blists - more mailing lists