netdev - Re: [PATCHv3 net-next 01/14] selftests/net: add lib.sh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87jzpr5x0r.fsf@nvidia.com>
Date: Wed, 6 Dec 2023 13:32:04 +0100
From: Petr Machata <petrm@...dia.com>
To: Paolo Abeni <pabeni@...hat.com>
CC: Hangbin Liu <liuhangbin@...il.com>, <netdev@...r.kernel.org>, "David S.
 Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, "Eric
 Dumazet" <edumazet@...gle.com>, Shuah Khan <shuah@...nel.org>, David Ahern
	<dsahern@...nel.org>, <linux-kselftest@...r.kernel.org>, Po-Hsu Lin
	<po-hsu.lin@...onical.com>, Guillaume Nault <gnault@...hat.com>, "Petr
 Machata" <petrm@...dia.com>, James Prestwood <prestwoj@...il.com>, "Jaehee
 Park" <jhpark1013@...il.com>, Ido Schimmel <idosch@...dia.com>, "Justin
 Iurman" <justin.iurman@...ege.be>, Xin Long <lucien.xin@...il.com>, "James
 Chapman" <jchapman@...alix.com>
Subject: Re: [PATCHv3 net-next 01/14] selftests/net: add lib.sh

Paolo Abeni <pabeni@...hat.com> writes:

> Side note for a possible follow-up: if you maintain $ns_list as global
> variable, and remove from such list the ns deleted by cleanup_ns, you
> could remove the cleanup trap from the individual test with something
> alike:
>
> final_cleanup_ns()
> {
> 	cleanup_ns $ns_list
> }
>
> trap final_cleanup_ns EXIT
>
> No respin needed for the above, could be a follow-up if agreed upon.

If you propose this for the library then I'm against it. The exit trap
is a global resource that the client scripts sometimes need to use as
well, to do topology teardowns or just general cleanups. So either the
library would have to provide APIs for cleanup management, or the trap
is for exclusive use by clients. The latter is IMHO simpler.

It also puts the cleanups at the same place where the acquisition is
prompted: the client allocates the NS, the client should prompt its
cleanup.