netdev - Re: [RFC] ethtool: raw packet filtering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231206081605.0fad0f58@kernel.org>
Date: Wed, 6 Dec 2023 08:16:05 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Ahmed Zaki <ahmed.zaki@...el.com>
Cc: <netdev@...r.kernel.org>, <davem@...emloft.net>, <edumazet@...gle.com>,
 <pabeni@...hat.com>, <mkubecek@...e.cz>, "Chittim, Madhu"
 <madhu.chittim@...el.com>, "Samudrala, Sridhar"
 <sridhar.samudrala@...el.com>
Subject: Re: [RFC] ethtool: raw packet filtering

On Tue, 5 Dec 2023 11:23:34 -0700 Ahmed Zaki wrote:
> We are planning to send a patch series that enables raw packet filtering 
> for ice and iavf. However, ethtool currently allows raw filtering on 
> only 8 bytes via "user-def":
> 
>    # ethtool -N eth0 flow-type user-def N [m N] action N
> 
> 
> We are seeking the community's opinion on how to extend the ntuple 
> interface to allow for up to 512 bytes of raw packet filtering. The 
> direct approach is:
> 
>    # ethtool -N eth0 flow-type raw-fltr N [m N] action N
> 
> where N would be allowed to be 512 bytes. Would that be acceptable? Any 
> concerns regarding netlink or other user-space/kernel comm?

We need more info about the use case and what this will achieve.
Asking if you can extend uAPI is like asking if you can walk in
the street. Sometimes you can sometimes you can't. All depends
on context, so start with the context, please.