netdev - Re: [PATCH net] net: core: synchronize link-watch when carrier is queried

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a840db62053cf5d3594effd9b1da8761be5676ee.camel@sipsolutions.net>
Date: Wed, 06 Dec 2023 01:12:26 +0100
From: Johannes Berg <johannes@...solutions.net>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH net] net: core: synchronize link-watch when carrier is
 queried

On Tue, 2023-12-05 at 16:11 -0800, Jakub Kicinski wrote:
> On Mon,  4 Dec 2023 21:47:07 +0100 Johannes Berg wrote:
> > There are multiple ways to query for the carrier state: through
> > rtnetlink, sysfs, and (possibly) ethtool. Synchronize linkwatch
> > work before these operations so that we don't have a situation
> > where userspace queries the carrier state between the driver's
> > carrier off->on transition and linkwatch running and expects it
> > to work, when really (at least) TX cannot work until linkwatch
> > has run.
> > 
> > I previously posted a longer explanation of how this applies to
> > wireless [1] but with this wireless can simply query the state
> > before sending data, to ensure the kernel is ready for it.
> 
> Are you okay with net-next?
> The previous behavior is, herm... well established.

Err, yeah, sure! Not sure I can tell you now how I ended up with net
there.

johannes