netdev - Re: [PATCH net v2] net: ipv6: support reporting otherwise unknown prefix flags in RTM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANP3RGewCVT8fATuL3tfVAkE-zgZQpJhNSKJJp6Rc37+2fTofA@mail.gmail.com>
Date: Wed, 6 Dec 2023 09:03:31 -0800
From: Maciej Żenczykowski <maze@...gle.com>
To: Eric Dumazet <edumazet@...gle.com>
Cc: Linux Network Development Mailing List <netdev@...r.kernel.org>, "David S . Miller" <davem@...emloft.net>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Shirley Ma <mashirle@...ibm.com>, 
	David Ahern <dsahern@...nel.org>, Lorenzo Colitti <lorenzo@...gle.com>
Subject: Re: [PATCH net v2] net: ipv6: support reporting otherwise unknown
 prefix flags in RTM_NEWPREFIX

On Wed, Dec 6, 2023 at 6:18 AM Eric Dumazet <edumazet@...gle.com> wrote:
> On Wed, Dec 6, 2023 at 3:10 PM Maciej Żenczykowski <maze@...gle.com> wrote:
> > +       union __attribute__((packed)) {
> > +               __u8            flags;
> > +               struct __attribute__((packed)) {
>
> For non uapi, it is recommended to use __packed instead of
> __attribute__((packed))

Ah, yes, and checkpatch even finds that.  Fixed in v3.

On patchworks I also see a complaint about the Fixes tag referencing a
non-existing commit:

Commit: d993c6f5d7e7 ("net: ipv6: support reporting otherwise unknown
prefix flags in RTM_NEWPREFIX")
Fixes tag: Fixes: 60872d54d963 ("[IPV6]: Add notification for
MIB:ipv6Prefix events.")
Has these problem(s):
- Target SHA1 does not exist

I (automatically) pulled it (via git blame) from tglx-history @
https://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git
graft...
$ git log --oneline -n1
remotes/tglx-history/v2.6.2..60872d54d963eefeb302ebeae15204e4be229c2b

I'm not sure... would it be better to just not include a fixes tag at
all and just CC stable@?