netdev - Re: [PATCH v2 net] net: dsa: microchip: provide a list of valid protocols for xmit handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <2244A511-6F6F-4711-9BE0-30786B021AE5@geanix.com>
Date: Wed, 6 Dec 2023 18:45:12 +0100
From: Sean Nyekjaer <sean@...nix.com>
To: Vladimir Oltean <olteanv@...il.com>,
 Madhuri.Sripada@...rochip.com
Cc: Woojung.Huh@...rochip.com,
 UNGLinuxDriver@...rochip.com,
 andrew@...n.ch,
 f.fainelli@...il.com,
 davem@...emloft.net,
 edumazet@...gle.com,
 kuba@...nel.org,
 pabeni@...hat.com,
 Arun.Ramadoss@...rochip.com,
 ceggers@...i.de,
 netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 net] net: dsa: microchip: provide a list of valid
 protocols for xmit handler

Hi Vladimir and Madhuri,

> On 6 Dec 2023, at 18.35, Vladimir Oltean <olteanv@...il.com> wrote:
> 
> On Wed, Dec 06, 2023 at 05:22:55PM +0000, Madhuri.Sripada@...rochip.com wrote:
>> NULL check is missing here.

Did here what every other driver does, that uses the connect_tag_protocol() method.
(As per Vladimir’s instructions)
Not one of them, does a NULL check.

> 
> Don't just leave it there, also explain why.

Message to me?

/Sean