netdev - Re: [PATCH net-next v2 6/9] net: wan/ixp4xx_hss: Convert to platform remove callback returning void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdbszYnpuDYeUCKiMwJvV9tq8b4Yq8bmsTr7vK5g_b=Qng@mail.gmail.com>
Date: Tue, 5 Dec 2023 23:43:19 +0100
From: Linus Walleij <linus.walleij@...aro.org>
To: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Linus Walleij <linusw@...nel.org>, 
	Imre Kaloz <kaloz@...nwrt.org>, linux-arm-kernel@...ts.infradead.org, 
	netdev@...r.kernel.org, kernel@...gutronix.de
Subject: Re: [PATCH net-next v2 6/9] net: wan/ixp4xx_hss: Convert to platform
 remove callback returning void

On Mon, Dec 4, 2023 at 7:31 PM Uwe Kleine-König
<u.kleine-koenig@...gutronix.de> wrote:

> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
>
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Link: https://lore.kernel.org/r/20231117095922.876489-8-u.kleine-koenig@pengutronix.de
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

Acked-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij