netdev - Re: [PATCH iwl-next] ice: Do not get coalesce settings while in reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZXCxUkkJ72SIhGt2@baltimore>
Date: Wed, 6 Dec 2023 18:37:22 +0100
From: Pawel Chmielewski <pawel.chmielewski@...el.com>
To: Przemek Kitszel <przemyslaw.kitszel@...el.com>
CC: <intel-wired-lan@...ts.osuosl.org>, <netdev@...r.kernel.org>, "Ngai-Mint
 Kwan" <ngai-mint.kwan@...el.com>, Mateusz Polchlopek
	<mateusz.polchlopek@...el.com>
Subject: Re: [PATCH iwl-next] ice: Do not get coalesce settings while in reset

On Tue, Dec 05, 2023 at 05:09:48PM +0100, Przemek Kitszel wrote:
> On 12/5/23 16:26, Pawel Chmielewski wrote:
> > From: Ngai-Mint Kwan <ngai-mint.kwan@...el.com>
> > 
> > Getting coalesce settings while reset is in progress can cause NULL
> > pointer deference bug.
> > If under reset, abort get coalesce for ethtool.
> > 
> > Signed-off-by: Ngai-Mint Kwan <ngai-mint.kwan@...el.com>
> > Reviewed-by: Mateusz Polchlopek <mateusz.polchlopek@...el.com>
> > Signed-off-by: Pawel Chmielewski <pawel.chmielewski@...el.com>
> > ---
> >   drivers/net/ethernet/intel/ice/ice_ethtool.c | 3 +++
> >   1 file changed, 3 insertions(+)
> > 
> > diff --git a/drivers/net/ethernet/intel/ice/ice_ethtool.c b/drivers/net/ethernet/intel/ice/ice_ethtool.c
> > index bde9bc74f928..2d565cc484a0 100644
> > --- a/drivers/net/ethernet/intel/ice/ice_ethtool.c
> > +++ b/drivers/net/ethernet/intel/ice/ice_ethtool.c
> > @@ -3747,6 +3747,9 @@ __ice_get_coalesce(struct net_device *netdev, struct ethtool_coalesce *ec,
> >   	struct ice_netdev_priv *np = netdev_priv(netdev);
> >   	struct ice_vsi *vsi = np->vsi;
> > +	if (ice_is_reset_in_progress(vsi->back->state))
> > +		return -EBUSY;
> > +
> >   	if (q_num < 0)
> >   		q_num = 0;
> 
> Sorry for a late review,
> This asks for a Fixes: tag, and targeting at iwl-net instead :)

Will fix the target, add the tag and send v2 right away :)