netdev - RE: [Intel-wired-lan] [PATCH iwl-net, v2] iavf: Fix iavf_shutdown to call iavf_remove instead iavf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BL0PR11MB3521B3E9C6784B5124B0074F8F84A@BL0PR11MB3521.namprd11.prod.outlook.com>
Date: Wed, 6 Dec 2023 19:39:46 +0000
From: "Romanowski, Rafal" <rafal.romanowski@...el.com>
To: "Rao, Ranganatha" <ranganatha.rao@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "Laba, SlawomirX" <slawomirx.laba@...el.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
	"Zaki, Ahmed" <ahmed.zaki@...el.com>, "Rao, Ranganatha"
	<ranganatha.rao@...el.com>, Michal Swiatkowski
	<michal.swiatkowski@...ux.intel.com>
Subject: RE: [Intel-wired-lan] [PATCH iwl-net, v2] iavf: Fix iavf_shutdown to
 call iavf_remove instead iavf_close

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Ranganatha Rao
> Sent: Wednesday, November 29, 2023 4:35 PM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: Laba, SlawomirX <slawomirx.laba@...el.com>; netdev@...r.kernel.org;
> Brandeburg, Jesse <jesse.brandeburg@...el.com>; Zaki, Ahmed
> <ahmed.zaki@...el.com>; Rao, Ranganatha <ranganatha.rao@...el.com>;
> Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
> Subject: [Intel-wired-lan] [PATCH iwl-net, v2] iavf: Fix iavf_shutdown to call
> iavf_remove instead iavf_close
> 
> From: Slawomir Laba <slawomirx.laba@...el.com>
> 
> Make the flow for pci shutdown be the same to the pci remove.
> 
> iavf_shutdown was implementing an incomplete version of iavf_remove. It
> misses several calls to the kernel like iavf_free_misc_irq,
> iavf_reset_interrupt_capability, iounmap that might break the system on
> reboot or hibernation.
> 
> Implement the call of iavf_remove directly in iavf_shutdown to close this gap.
> 
> Fixes below error messages (dmesg) during shutdown stress tests -
> [685814.900917] ice 0000:88:00.0: MAC 02:d0:5f:82:43:5d does not exist
> for  VF 0 [685814.900928] ice 0000:88:00.0: MAC 33:33:00:00:00:01 does
> not exist for VF 0
> 
> Reproduction:
> 
> 1. Create one VF interface:
> echo 1 > /sys/class/net/<interface_name>/device/sriov_numvfs
> 
> 2. Run live dmesg on the host:
> dmesg -wH
> 
> 3. On SUT, script below steps into vf_namespace_assignment.sh
> 
> <#!/bin/sh> // Remove <>. Git removes # line if=<VF name> (edit this per VF
> name)
> loop=0
> 
> while true; do
> 
> echo test round $loop
> let loop++
> 
> ip netns add ns$loop
> ip link set dev $if up
> ip link set dev $if netns ns$loop
> ip netns exec ns$loop ip link set dev $if up ip netns exec ns$loop ip link set dev
> $if netns 1 ip netns delete ns$loop
> 
> done
> 
> 4. Run the script for at least 1000 iterations on SUT:
> ./vf_namespace_assignment.sh
> 
> Expected result:
> No errors in dmesg.
> 
> Fixes: 129cf89e5856 ("iavf: rename functions and structs to new name")
> Signed-off-by: Slawomir Laba <slawomirx.laba@...el.com>
> Reviewed-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
> Reviewed-by: Ahmed Zaki <ahmed.zaki@...el.com>
> Reviewed-by: Jesse Brandeburg <jesse.brandeburg@...el.com>
> Co-authored-by: Ranganatha Rao <ranganatha.rao@...el.com>
> Signed-off-by: Ranganatha Rao <ranganatha.rao@...el.com>
> 
> ---
> v2: Add reproduction steps in commit log
> ---
>  drivers/net/ethernet/intel/iavf/iavf_main.c | 72 ++++++---------------
>  1 file changed, 21 insertions(+), 51 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c
> b/drivers/net/ethernet/intel/iavf/iavf_main.c
> index c862ebcd2e39..3c177dcd3b38 100644
> --- a/drivers/net/ethernet/intel/iavf/iavf_main.c
> +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c


Tested-by: Rafal Romanowski <rafal.romanowski@...el.com>