netdev - Re: [PATCH net] net: dsa: mv88e6xxx: Restore USXGMII support for 6393X

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0e2cb20b-3be7-4f33-aef1-170967ba7e85@lunn.ch>
Date: Wed, 6 Dec 2023 22:07:34 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Michal Smulski <michal.smulski@...a.com>
Cc: Tobias Waldekranz <tobias@...dekranz.com>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"kuba@...nel.org" <kuba@...nel.org>,
	"f.fainelli@...il.com" <f.fainelli@...il.com>,
	"olteanv@...il.com" <olteanv@...il.com>,
	"linux@...linux.org.uk" <linux@...linux.org.uk>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net] net: dsa: mv88e6xxx: Restore USXGMII support for
 6393X

On Wed, Dec 06, 2023 at 08:37:50PM +0000, Michal Smulski wrote:
> I confirm that applying this patch to net-next tree works (and it is required) on my hardware.
> 
> Here is log from the kernel running on the actual hardware:
> [   49.818070] mv88e6085 0x0000000008b96000:02: switch 0x1920 detected: Marvell 88E6191X, revision 0
> [   50.429506] mv88e6085 0x0000000008b96000:02: configuring for inband/usxgmii link mode
> [   50.509099] mv88e6085 0x0000000008b96000:02 p1 (uninitialized): PHY [!soc!mdio@...6000!switch0@...dio:01] driver [Marvell 88E6393 Family] (irq=388)
> [   50.577062] mv88e6085 0x0000000008b96000:02 p2 (uninitialized): PHY [!soc!mdio@...6000!switch0@...dio:02] driver [Marvell 88E6393 Family] (irq=389)
> [   50.635256] mv88e6085 0x0000000008b96000:02: Link is Up - 10Gbps/Full - flow control off
> [   50.641109] mv88e6085 0x0000000008b96000:02 p3 (uninitialized): PHY [!soc!mdio@...6000!switch0@...dio:03] driver [Marvell 88E6393 Family] (irq=391)
> [   50.697091] mv88e6085 0x0000000008b96000:02 p4 (uninitialized): PHY [!soc!mdio@...6000!switch0@...dio:04] driver [Marvell 88E6393 Family] (irq=392)
> [   50.725072] mv88e6085 0x0000000008b96000:02 p5 (uninitialized): PHY [!soc!mdio@...6000!switch0@...dio:05] driver [Marvell 88E6393 Family] (irq=393)
> [   50.753074] mv88e6085 0x0000000008b96000:02 p6 (uninitialized): PHY [!soc!mdio@...6000!switch0@...dio:06] driver [Marvell 88E6393 Family] (irq=394)
> [   50.781085] mv88e6085 0x0000000008b96000:02 p7 (uninitialized): PHY [!soc!mdio@...6000!switch0@...dio:07] driver [Marvell 88E6393 Family] (irq=395)
> [   50.809080] mv88e6085 0x0000000008b96000:02 p8 (uninitialized): PHY [!soc!mdio@...6000!switch0@...dio:08] driver [Marvell 88E6393 Family] (irq=396)
> [   50.815677] DSA: tree 0 setup
> [  170.719608] fsl_dpaa2_eth dpni.3 eth1: configuring for inband/usxgmii link mode
> [  170.735697] fsl_dpaa2_eth dpni.3 eth1: Link is Up - 10Gbps/Full - flow control off
> [  170.813015] mv88e6085 0x0000000008b96000:02 p8: configuring for phy/gmii link mode
> [  170.913510] mv88e6085 0x0000000008b96000:02 p7: configuring for phy/gmii link mode
> [  171.014155] mv88e6085 0x0000000008b96000:02 p6: configuring for phy/gmii link mode
> [  171.119832] mv88e6085 0x0000000008b96000:02 p5: configuring for phy/gmii link mode
> [  171.230594] mv88e6085 0x0000000008b96000:02 p4: configuring for phy/gmii link mode
> [  171.346344] mv88e6085 0x0000000008b96000:02 p3: configuring for phy/gmii link mode
> [  171.472394] mv88e6085 0x0000000008b96000:02 p2: configuring for phy/gmii link mode
> [  171.594045] mv88e6085 0x0000000008b96000:02 p1: configuring for phy/gmii link mode
> [  969.248179] mv88e6085 0x0000000008b96000:02 p8: Link is Up - 1Gbps/Full - flow control rx/tx
> [ 1089.691582] mv88e6085 0x0000000008b96000:02 p8: Link is Down
> [ 1452.761369] mv88e6085 0x0000000008b96000:02 p8: Link is Up - 1Gbps/Full - flow control rx/tx
> 
> 
> Michal

Hi Michal

Would you mind adding a Tested-by:

See https://www.kernel.org/doc/html/latest/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes

    Andrew