netdev - Re: [PATCH] net: dsa: microchip: fix NULL pointer dereference on platform init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20231206214928.jhx6naeo2o2eonj5@skbuf>
Date: Wed, 6 Dec 2023 23:49:28 +0200
From: Vladimir Oltean <olteanv@...il.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: Daniel Danzberger <dd@...edd.com>, woojung.huh@...rochip.com,
	UNGLinuxDriver@...rochip.com, netdev@...r.kernel.org,
	Florian Fainelli <f.fainelli@...il.com>
Subject: Re: [PATCH] net: dsa: microchip: fix NULL pointer dereference on
 platform init

On Wed, Dec 06, 2023 at 04:26:52PM +0100, Andrew Lunn wrote:
> > So, surprisingly, there is enough redundancy between DSA mechanisms that
> > platform_data kinda works.
> 
> I have x86 platforms using mv88e6xxx with platform data. Simple
> systems do work, the platforms i have only make use of the internal
> PHYs. This is partially because of history. DSA is older than the
> adoption of DT. The mv88e6xxx driver and DSA used to be purely
> platform data driven, and we have not yet broken that.
> 
> 	Andrew

I'm not saying that platform_data did not have its time and place, but
Device Tree clearly won, and platform_data is a rarely untested minority
nowadays.

We don't have to break platform_data in mv88e6xxx and in the DSA core
all of a sudden. It can coexist with software nodes for a while, as
alternative solutions to the same problem.