lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20231205192346.4409ee16@kernel.org>
Date: Tue, 5 Dec 2023 19:23:46 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Jijie Shao <shaojijie@...wei.com>
Cc: Arnd Bergmann <arnd@...nel.org>, Yisen Zhuang <yisen.zhuang@...wei.com>,
 Salil Mehta <salil.mehta@...wei.com>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
 <pabeni@...hat.com>, Arnd Bergmann <arnd@...db.de>, Hao Chen
 <chenhao418@...wei.com>, <netdev@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] [v2] net: hns3: reduce stack usage in
 hclge_dbg_dump_tm_pri()

On Mon, 4 Dec 2023 22:50:55 +0800 Jijie Shao wrote:
> >   static int hclge_dbg_dump_tm_pri(struct hclge_dev *hdev, char *buf, int len)
> >   {
> > -	char data_str[ARRAY_SIZE(tm_pri_items)][HCLGE_DBG_DATA_STR_LEN];
> > +	char *data_str;  
> 
> We want to define variables in an inverted triangle based on the code length.
> so, "char *data_str" should move four lines down.
> 
>    	struct hclge_tm_shaper_para c_shaper_para, p_shaper_para;
> 	char *result[ARRAY_SIZE(tm_pri_items)], *sch_mode_str;
> 	char content[HCLGE_DBG_TM_INFO_LEN];
> 	u8 pri_num, sch_mode, weight, i, j;
> 	char *data_str;
> 	int pos, ret;

I took the liberty of fixing this when applying.
Don't want this to fall thru the cracks.

Applied to net-next now, thanks!

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ