netdev - Re: [RFC PATCH v2 1/8] dt-bindings: phy: mediatek,xfi-pextp: add new bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <170183397288.462976.3952343134089704927.robh@kernel.org>
Date: Tue, 05 Dec 2023 21:39:36 -0600
From: Rob Herring <robh@...nel.org>
To: Daniel Golle <daniel@...rotopia.org>
Cc: Eric Dumazet <edumazet@...gle.com>, Qingfang Deng <dqfext@...il.com>, 
	Rob Herring <robh+dt@...nel.org>, Alexander Couzens <lynxis@...0.eu>, 
	Russell King <linux@...linux.org.uk>, Paolo Abeni <pabeni@...hat.com>, linux-kernel@...r.kernel.org, 
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, Vinod Koul <vkoul@...nel.org>, 
	SkyLake Huang <SkyLake.Huang@...iatek.com>, Matthias Brugger <matthias.bgg@...il.com>, 
	Lorenzo Bianconi <lorenzo@...nel.org>, linux-phy@...ts.infradead.org, 
	Felix Fietkau <nbd@....name>, Chunfeng Yun <chunfeng.yun@...iatek.com>, 
	Conor Dooley <conor+dt@...nel.org>, netdev@...r.kernel.org, 
	"David S. Miller" <davem@...emloft.net>, linux-arm-kernel@...ts.infradead.org, 
	Jakub Kicinski <kuba@...nel.org>, Andrew Lunn <andrew@...n.ch>, Sean Wang <sean.wang@...iatek.com>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, 
	Kishon Vijay Abraham I <kishon@...nel.org>, Heiner Kallweit <hkallweit1@...il.com>, 
	linux-mediatek@...ts.infradead.org, Philipp Zabel <p.zabel@...gutronix.de>, 
	John Crispin <john@...ozen.org>, Mark Lee <Mark-MC.Lee@...iatek.com>, devicetree@...r.kernel.org
Subject: Re: [RFC PATCH v2 1/8] dt-bindings: phy: mediatek,xfi-pextp: add
 new bindings


On Wed, 06 Dec 2023 01:43:55 +0000, Daniel Golle wrote:
> Add bindings for the MediaTek PEXTP Ethernet SerDes PHY found in the
> MediaTek MT7988 SoC which can operate at various interfaces modes:
> 
>  * USXGMII
>  * 10GBase-R
>  * 5GBase-R
>  * 2500Base-X
>  * 1000Base-X
>  * Cisco SGMII (MAC side)
> 
> Signed-off-by: Daniel Golle <daniel@...rotopia.org>
> ---
>  .../bindings/phy/mediatek,xfi-pextp.yaml      | 80 +++++++++++++++++++
>  1 file changed, 80 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/phy/mediatek,xfi-pextp.yaml
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:
./Documentation/devicetree/bindings/phy/mediatek,xfi-pextp.yaml:33:16: [error] string value is redundantly quoted with any quotes (quoted-strings)
./Documentation/devicetree/bindings/phy/mediatek,xfi-pextp.yaml:34:16: [error] string value is redundantly quoted with any quotes (quoted-strings)

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/phy/mediatek,xfi-pextp.example.dts:18:18: fatal error: dt-bindings/clock/mediatek,mt7988-clk.h: No such file or directory
   18 |         #include <dt-bindings/clock/mediatek,mt7988-clk.h>
      |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [scripts/Makefile.lib:419: Documentation/devicetree/bindings/phy/mediatek,xfi-pextp.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1424: dt_binding_check] Error 2
make: *** [Makefile:234: __sub-make] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/f57cc2bfadca35219707a0af507ad6e2e354e311.1701826319.git.daniel@makrotopia.org

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.