| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID:
<AM5PR04MB31397A652DD88CE04078B569888BA@AM5PR04MB3139.eurprd04.prod.outlook.com>
Date: Thu, 7 Dec 2023 07:19:56 +0000
From: Wei Fang <wei.fang@....com>
To: "justinstitt@...gle.com" <justinstitt@...gle.com>, "David S. Miller"
<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Shay Agroskin
<shayagr@...zon.com>, Arthur Kiyanovski <akiyano@...zon.com>, David Arinzon
<darinzon@...zon.com>, Noam Dagan <ndagan@...zon.com>, Saeed Bishara
<saeedb@...zon.com>, Rasesh Mody <rmody@...vell.com>, Sudarsana Kalluru
<skalluru@...vell.com>, "GR-Linux-NIC-Dev@...vell.com"
<GR-Linux-NIC-Dev@...vell.com>, Dimitris Michailidis <dmichail@...gible.com>,
Yisen Zhuang <yisen.zhuang@...wei.com>, Salil Mehta <salil.mehta@...wei.com>,
Jesse Brandeburg <jesse.brandeburg@...el.com>, Tony Nguyen
<anthony.l.nguyen@...el.com>, Louis Peens <louis.peens@...igine.com>, Shannon
Nelson <shannon.nelson@....com>, Brett Creeley <brett.creeley@....com>,
"drivers@...sando.io" <drivers@...sando.io>, "K. Y. Srinivasan"
<kys@...rosoft.com>, Haiyang Zhang <haiyangz@...rosoft.com>, Wei Liu
<wei.liu@...nel.org>, Dexuan Cui <decui@...rosoft.com>, Ronak Doshi
<doshir@...are.com>, VMware PV-Drivers Reviewers <pv-drivers@...are.com>,
Andy Whitcroft <apw@...onical.com>, Joe Perches <joe@...ches.com>, Dwaipayan
Ray <dwaipayanray1@...il.com>, Lukas Bulwahn <lukas.bulwahn@...il.com>, Hauke
Mehrtens <hauke@...ke-m.de>, Andrew Lunn <andrew@...n.ch>, Florian Fainelli
<f.fainelli@...il.com>, Vladimir Oltean <olteanv@...il.com>,
Arınç ÜNAL <arinc.unal@...nc9.com>, Daniel Golle
<daniel@...rotopia.org>, Landen Chao <Landen.Chao@...iatek.com>, DENG
Qingfang <dqfext@...il.com>, Sean Wang <sean.wang@...iatek.com>, Matthias
Brugger <matthias.bgg@...il.com>, AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com>, Linus Walleij
<linus.walleij@...aro.org>, Alvin Šipraga
<alsi@...g-olufsen.dk>, Shenwei Wang <shenwei.wang@....com>, Clark Wang
<xiaoning.wang@....com>, dl-linux-imx <linux-imx@....com>, Lars Povlsen
<lars.povlsen@...rochip.com>, Steen Hegelund <Steen.Hegelund@...rochip.com>,
Daniel Machon <daniel.machon@...rochip.com>, "UNGLinuxDriver@...rochip.com"
<UNGLinuxDriver@...rochip.com>, Jiawen Wu <jiawenwu@...stnetic.com>, Mengyuan
Lou <mengyuanlou@...-swift.com>, Heiner Kallweit <hkallweit1@...il.com>,
Russell King <linux@...linux.org.uk>, Alexei Starovoitov <ast@...nel.org>,
Daniel Borkmann <daniel@...earbox.net>, Jesper Dangaard Brouer
<hawk@...nel.org>, John Fastabend <john.fastabend@...il.com>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>, Nick Desaulniers
<ndesaulniers@...gle.com>, Nathan Chancellor <nathan@...nel.org>, Kees Cook
<keescook@...omium.org>, "intel-wired-lan@...ts.osuosl.org"
<intel-wired-lan@...ts.osuosl.org>, "oss-drivers@...igine.com"
<oss-drivers@...igine.com>, "linux-hyperv@...r.kernel.org"
<linux-hyperv@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>, "linux-mediatek@...ts.infradead.org"
<linux-mediatek@...ts.infradead.org>, "bpf@...r.kernel.org"
<bpf@...r.kernel.org>
Subject: RE: [PATCH net-next v5 3/3] net: Convert some ethtool_sprintf() to
ethtool_puts()
> -----Original Message-----
> From: justinstitt@...gle.com <justinstitt@...gle.com>
> Sent: 2023年12月7日 7:16
> To: David S. Miller <davem@...emloft.net>; Eric Dumazet
> <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo Abeni
> <pabeni@...hat.com>; Shay Agroskin <shayagr@...zon.com>; Arthur
> Kiyanovski <akiyano@...zon.com>; David Arinzon
> <darinzon@...zon.com>; Noam Dagan <ndagan@...zon.com>; Saeed
> Bishara <saeedb@...zon.com>; Rasesh Mody <rmody@...vell.com>;
> Sudarsana Kalluru <skalluru@...vell.com>; GR-Linux-NIC-Dev@...vell.com;
> Dimitris Michailidis <dmichail@...gible.com>; Yisen Zhuang
> <yisen.zhuang@...wei.com>; Salil Mehta <salil.mehta@...wei.com>; Jesse
> Brandeburg <jesse.brandeburg@...el.com>; Tony Nguyen
> <anthony.l.nguyen@...el.com>; Louis Peens <louis.peens@...igine.com>;
> Shannon Nelson <shannon.nelson@....com>; Brett Creeley
> <brett.creeley@....com>; drivers@...sando.io; K. Y. Srinivasan
> <kys@...rosoft.com>; Haiyang Zhang <haiyangz@...rosoft.com>; Wei Liu
> <wei.liu@...nel.org>; Dexuan Cui <decui@...rosoft.com>; Ronak Doshi
> <doshir@...are.com>; VMware PV-Drivers Reviewers
> <pv-drivers@...are.com>; Andy Whitcroft <apw@...onical.com>; Joe
> Perches <joe@...ches.com>; Dwaipayan Ray <dwaipayanray1@...il.com>;
> Lukas Bulwahn <lukas.bulwahn@...il.com>; Hauke Mehrtens
> <hauke@...ke-m.de>; Andrew Lunn <andrew@...n.ch>; Florian Fainelli
> <f.fainelli@...il.com>; Vladimir Oltean <olteanv@...il.com>; Arınç ÜNAL
> <arinc.unal@...nc9.com>; Daniel Golle <daniel@...rotopia.org>; Landen
> Chao <Landen.Chao@...iatek.com>; DENG Qingfang <dqfext@...il.com>;
> Sean Wang <sean.wang@...iatek.com>; Matthias Brugger
> <matthias.bgg@...il.com>; AngeloGioacchino Del Regno
> <angelogioacchino.delregno@...labora.com>; Linus Walleij
> <linus.walleij@...aro.org>; Alvin Šipraga <alsi@...g-olufsen.dk>; Wei Fang
> <wei.fang@....com>; Shenwei Wang <shenwei.wang@....com>; Clark
> Wang <xiaoning.wang@....com>; dl-linux-imx <linux-imx@....com>; Lars
> Povlsen <lars.povlsen@...rochip.com>; Steen Hegelund
> <Steen.Hegelund@...rochip.com>; Daniel Machon
> <daniel.machon@...rochip.com>; UNGLinuxDriver@...rochip.com; Jiawen
> Wu <jiawenwu@...stnetic.com>; Mengyuan Lou
> <mengyuanlou@...-swift.com>; Heiner Kallweit <hkallweit1@...il.com>;
> Russell King <linux@...linux.org.uk>; Alexei Starovoitov <ast@...nel.org>;
> Daniel Borkmann <daniel@...earbox.net>; Jesper Dangaard Brouer
> <hawk@...nel.org>; John Fastabend <john.fastabend@...il.com>
> Cc: linux-kernel@...r.kernel.org; netdev@...r.kernel.org; Nick Desaulniers
> <ndesaulniers@...gle.com>; Nathan Chancellor <nathan@...nel.org>; Kees
> Cook <keescook@...omium.org>; intel-wired-lan@...ts.osuosl.org;
> oss-drivers@...igine.com; linux-hyperv@...r.kernel.org;
> linux-arm-kernel@...ts.infradead.org; linux-mediatek@...ts.infradead.org;
> bpf@...r.kernel.org; Justin Stitt <justinstitt@...gle.com>
> Subject: [PATCH net-next v5 3/3] net: Convert some ethtool_sprintf() to
> ethtool_puts()
>
> This patch converts some basic cases of ethtool_sprintf() to ethtool_puts().
>
> The conversions are used in cases where ethtool_sprintf() was being used
> with just two arguments:
> | ethtool_sprintf(&data, buffer[i].name);
> or when it's used with format string: "%s"
> | ethtool_sprintf(&data, "%s", buffer[i].name);
> which both now become:
> | ethtool_puts(&data, buffer[i].name);
>
> Signed-off-by: Justin Stitt <justinstitt@...gle.com>
> ---
> drivers/net/ethernet/freescale/fec_main.c | 4 +-
> diff --git a/drivers/net/ethernet/freescale/fec_main.c
> b/drivers/net/ethernet/freescale/fec_main.c
> index c3b7694a7485..bae9536de767 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -2932,10 +2932,10 @@ static void fec_enet_get_strings(struct
> net_device *netdev,
> switch (stringset) {
> case ETH_SS_STATS:
> for (i = 0; i < ARRAY_SIZE(fec_stats); i++) {
> - ethtool_sprintf(&data, "%s", fec_stats[i].name);
> + ethtool_puts(&data, fec_stats[i].name);
> }
> for (i = 0; i < ARRAY_SIZE(fec_xdp_stat_strs); i++) {
> - ethtool_sprintf(&data, "%s", fec_xdp_stat_strs[i]);
> + ethtool_puts(&data, fec_xdp_stat_strs[i]);
> }
> page_pool_ethtool_stats_get_strings(data);
>
Reviewed-by: Wei Fang <wei.fang@....com>
Powered by blists - more mailing lists