netdev - RE: [PATCH iwl-next v4 06/12] ice: Add device state save/load function for migration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BN9PR11MB52766670994F9AD205F16B278C8BA@BN9PR11MB5276.namprd11.prod.outlook.com>
Date: Thu, 7 Dec 2023 07:39:15 +0000
From: "Tian, Kevin" <kevin.tian@...el.com>
To: "Cao, Yahui" <yahui.cao@...el.com>, "intel-wired-lan@...ts.osuosl.org"
	<intel-wired-lan@...ts.osuosl.org>
CC: "kvm@...r.kernel.org" <kvm@...r.kernel.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "Liu, Lingyu" <lingyu.liu@...el.com>, "Chittim,
 Madhu" <madhu.chittim@...el.com>, "Samudrala, Sridhar"
	<sridhar.samudrala@...el.com>, "alex.williamson@...hat.com"
	<alex.williamson@...hat.com>, "jgg@...dia.com" <jgg@...dia.com>,
	"yishaih@...dia.com" <yishaih@...dia.com>,
	"shameerali.kolothum.thodi@...wei.com"
	<shameerali.kolothum.thodi@...wei.com>, "brett.creeley@....com"
	<brett.creeley@....com>, "davem@...emloft.net" <davem@...emloft.net>,
	"edumazet@...gle.com" <edumazet@...gle.com>, "kuba@...nel.org"
	<kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>
Subject: RE: [PATCH iwl-next v4 06/12] ice: Add device state save/load
 function for migration

> From: Cao, Yahui <yahui.cao@...el.com>
> Sent: Tuesday, November 21, 2023 10:51 AM
> +
> +	while (msg_slot->opcode != VIRTCHNL_OP_UNKNOWN) {
> +		struct ice_rq_event_info event;
> +		u64 slot_sz;
> +
> +		slot_sz = struct_size(msg_slot, msg_buffer, msg_slot-
> >msg_len);
> +		dev_dbg(dev, "VF %d replay virtchnl message op code: %d,
> msg len: %d\n",
> +			vf->vf_id, msg_slot->opcode, msg_slot->msg_len);
> +		event.desc.cookie_high = cpu_to_le32(msg_slot->opcode);
> +		event.msg_len = msg_slot->msg_len;
> +		event.desc.retval = cpu_to_le16(vf->vf_id);
> +		event.msg_buf = (unsigned char *)msg_slot->msg_buffer;
> +		ret = ice_vc_process_vf_msg(vf->pf, &event, NULL);
> +		if (ret) {
> +			dev_err(dev, "VF %d failed to replay virtchnl message
> op code: %d\n",
> +				vf->vf_id, msg_slot->opcode);
> +			goto out_clear_replay;
> +		}
> +		event.msg_buf = NULL;

this line is unnecessary.