netdev - Re: [EXT] Re: [PATCH] net: atlantic: fixed double free when constrained memory conditions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1d592ded-a702-5be0-6617-ecfcb4c41f92@marvell.com>
Date: Thu, 7 Dec 2023 10:29:59 +0100
From: Igor Russkikh <irusskikh@...vell.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: <netdev@...r.kernel.org>, "David S . Miller" <davem@...emloft.net>,
        Linus
 Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [EXT] Re: [PATCH] net: atlantic: fixed double free when
 constrained memory conditions


>>
>> Fixed by explicitly clearing pointers to NULL, also eliminate two
>> levels of aq_ring_free invocation.
> 
> The change of the return type plays no functional role in the fix,
> right?
> 
> I think it'd make the change far more readable if that was a separate
> patch. And if it's a separate, non-functional patch, it should go
> to net-next, rather than with the fix to net.

Makes sense, will split the patch.

Thanks
  Igor