netdev - RE: [PATCH net-next v3 8/9] net: rswitch: Add jumbo frames handling for TX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 7 Dec 2023 00:23:56 +0000
From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
To: Paolo Abeni <pabeni@...hat.com>, "s.shtylyov@....ru" <s.shtylyov@....ru>,
	"davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "kuba@...nel.org" <kuba@...nel.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-renesas-soc@...r.kernel.org" <linux-renesas-soc@...r.kernel.org>
Subject: RE: [PATCH net-next v3 8/9] net: rswitch: Add jumbo frames handling
 for TX

Hello Paolo,

> From: Paolo Abeni, Sent: Wednesday, December 6, 2023 7:21 PM
> 
> On Mon, 2023-12-04 at 10:20 +0900, Yoshihiro Shimoda wrote:
> > @@ -1647,25 +1676,32 @@ static netdev_tx_t rswitch_start_xmit(struct sk_buff *skb, struct net_device *nd
> >  	if (skb_put_padto(skb, ETH_ZLEN))
> >  		return ret;
> >
> > -	dma_addr = dma_map_single(ndev->dev.parent, skb->data, skb->len, DMA_TO_DEVICE);
> > -	if (dma_mapping_error(ndev->dev.parent, dma_addr))
> > +	dma_addr_orig = dma_map_single(ndev->dev.parent, skb->data, skb->len, DMA_TO_DEVICE);
> > +	if (dma_mapping_error(ndev->dev.parent, dma_addr_orig))
> >  		goto err_kfree;
> >
> >  	gq->skbs[gq->cur] = skb;
> >  	gq->unmap_addrs[gq->cur] = dma_addr;
> 
> Here 'dma_addr' is still used uninitialized. I guess you should use
> 'dma_addr_orig' even here.

Oops! I should fix it. I'll make v4 patch. Thank you for your review!

Best regards,
Yoshihiro Shimoda

> Cheers,
> 
> Paolo