[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20231207094220.77019dd0@kernel.org>
Date: Thu, 7 Dec 2023 09:42:20 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Suman Ghosh <sumang@...vell.com>
Cc: Zhipeng Lu <alexious@....edu.cn>, Chris Snook <chris.snook@...il.com>,
"David S. Miller" <davem@...emloft.net>, Eric Dumazet
<edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Simon Horman
<horms@...nel.org>, Yuanjun Gong <ruc_gongyuanjun@....com>, Jie Yang
<jie.yang@...eros.com>, Jeff Garzik <jgarzik@...hat.com>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [EXT] [PATCH] ethernet: atheros: fix a memleak in
atl1e_setup_ring_resources
On Thu, 7 Dec 2023 17:08:15 +0000 Suman Ghosh wrote:
> >+ kfree(tx_ring->tx_buffer);
>
> [Suman] I think we should do tx_ring->tx_buffer = NULL also, to avoid use after free?
It's up to the driver. Some may call that defensive programming.
Powered by blists - more mailing lists