[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20231207102214.4aa23d14@kernel.org>
Date: Thu, 7 Dec 2023 10:22:14 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Michael Chan <michael.chan@...adcom.com>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
pabeni@...hat.com, gospo@...adcom.com, Sreekanth Reddy
<sreekanth.reddy@...adcom.com>, Somnath Kotur <somnath.kotur@...adcom.com>,
Andy Gospodarek <andrew.gospodarek@...adcom.com>, Vikas Gupta
<vikas.gupta@...adcom.com>
Subject: Re: [PATCH net v2 2/4] bnxt_en: Fix skb recycling logic in
bnxt_deliver_skb()
On Thu, 7 Dec 2023 10:21:44 -0800 Jakub Kicinski wrote:
> On Wed, 6 Dec 2023 16:05:49 -0800 Michael Chan wrote:
> > Receive SKBs can go through the VF-rep path or the normal path.
> > skb_mark_for_recycle() is only called for the normal path. Fix it
> > to do it for both paths to fix possible stalled page pool shutdown
> > errors.
>
> This patch is probably fine, but since I'm complaining -
> IMHO it may be better to mark the skbs right after they
> are allocated. Catching all "exit points" seems very error
> prone...
To be 100% clear - I mean that as a suggestion for a potential
net-next cleanup.
Powered by blists - more mailing lists