netdev - Re: [PATCH bpf-next] ipv6: fix warning messages in fib6_info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e4d86104-0b66-4535-85bc-87bea2409a7e@gmail.com>
Date: Thu, 7 Dec 2023 12:24:53 -0800
From: Kui-Feng Lee <sinquersw@...il.com>
To: Eric Dumazet <edumazet@...gle.com>, thinker.li@...il.com
Cc: netdev@...r.kernel.org, martin.lau@...ux.dev, kernel-team@...a.com,
 davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com, dsahern@...nel.org,
 kuifeng@...a.com
Subject: Re: [PATCH bpf-next] ipv6: fix warning messages in
 fib6_info_release().

On 12/7/23 12:04, Eric Dumazet wrote:
> On Thu, Dec 7, 2023 at 8:50 PM <thinker.li@...il.com> wrote:
>>
>> From: Kui-Feng Lee <thinker.li@...il.com>
>>
>> The previous patch doesn't handle the case in ip6_route_info_create().
>> Move calling to fib6_set_expires_locked() to the end of the function to
>> avoid the false alarm of the previous patch.
>>
>> Fixes: 5a08d0065a91 ("ipv6: add debug checks in fib6_info_release()")
> 
> This looks quite wrong.
> 
> Let's separate things to have clean stable backports.
> 
> I will submit my single liner, you will submit a patch fixing your prior commit,
> otherwise linux-6.6 and linux-6.7 will still have a bug.

Sure, I am working on that.