netdev - Re: [PATCH wpan-next 3/5] mac802154: Only allow PAN controllers to process association requests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <75cd5a2b-38df-27dc-fcaa-418b50bd2f03@datenfreihafen.org>
Date: Thu, 7 Dec 2023 21:45:21 +0100
From: Stefan Schmidt <stefan@...enfreihafen.org>
To: Miquel Raynal <miquel.raynal@...tlin.com>,
 Alexander Aring <alex.aring@...il.com>, linux-wpan@...r.kernel.org
Cc: David Girault <david.girault@...vo.com>,
 Romuald Despres <romuald.despres@...vo.com>,
 Frederic Blain <frederic.blain@...vo.com>,
 Nicolas Schodet <nico@...fr.eu.org>,
 Guilhem Imberton <guilhem.imberton@...vo.com>,
 Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
 "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>,
 netdev@...r.kernel.org
Subject: Re: [PATCH wpan-next 3/5] mac802154: Only allow PAN controllers to
 process association requests

Hello.

On 28.11.23 12:16, Miquel Raynal wrote:
> It is not very clear in the specification whether simple coordinators
> are allowed or not to answer to association requests themselves. As
> there is no synchronization mechanism, it is probably best to rely on
> the relay feature of these coordinators and avoid processing them in
> this case.
> 
> Signed-off-by: Miquel Raynal <miquel.raynal@...tlin.com>
> ---
>   net/mac802154/scan.c | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/net/mac802154/scan.c b/net/mac802154/scan.c
> index 5873da634fb4..1c0eeaa76560 100644
> --- a/net/mac802154/scan.c
> +++ b/net/mac802154/scan.c
> @@ -781,6 +781,12 @@ int mac802154_process_association_req(struct ieee802154_sub_if_data *sdata,
>   		 unlikely(dest->short_addr != wpan_dev->short_addr))
>   		return -ENODEV;
>   
> +	if (wpan_dev->parent) {
> +		dev_dbg(&sdata->dev->dev,
> +			"Ignoring ASSOC REQ, not the PAN coordinator\n");
> +		return -ENODEV;
> +	}
> +
>   	mutex_lock(&wpan_dev->association_lock);
>   
>   	memcpy(&assoc_req_pl, skb->data, sizeof(assoc_req_pl));

Acked-by: Stefan Schmidt <stefan@...enfreihafen.org>

regards
Stefan Schmidt