netdev - Re: [PATCH net-next v3 3/5] rtnl: add helper to send if skb is not null

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231207210028.GL50400@kernel.org>
Date: Thu, 7 Dec 2023 21:00:28 +0000
From: Simon Horman <horms@...nel.org>
To: Pedro Tammela <pctammela@...atatu.com>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, jhs@...atatu.com,
	xiyou.wangcong@...il.com, jiri@...nulli.us,
	marcelo.leitner@...il.com, vladbu@...dia.com,
	Jiri Pirko <jiri@...dia.com>
Subject: Re: [PATCH net-next v3 3/5] rtnl: add helper to send if skb is not
 null

On Wed, Dec 06, 2023 at 01:44:14PM -0300, Pedro Tammela wrote:
> This is a convenience helper for routines handling conditional rtnl
> events, that is code that might send a notification depending on
> rtnl_has_listeners/rtnl_notify_needed.
> 
> Instead of:
>    if (skb)
>       rtnetlink_send(...)
> 
> Use:
>       rtnetlink_maybe_send(...)
> 
> Reviewed-by: Jiri Pirko <jiri@...dia.com>
> Signed-off-by: Pedro Tammela <pctammela@...atatu.com>

Reviewed-by: Simon Horman <horms@...nel.org>