netdev - RE: [PATCH v2] net: ena: replace deprecated strncpy with strscpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6a877c080404447c8f715c614b276bef@amazon.com>
Date: Thu, 7 Dec 2023 21:48:23 +0000
From: "Kiyanovski, Arthur" <akiyano@...zon.com>
To: "justinstitt@...gle.com" <justinstitt@...gle.com>, "Agroskin, Shay"
	<shayagr@...zon.com>, "Arinzon, David" <darinzon@...zon.com>, "Dagan, Noam"
	<ndagan@...zon.com>, "Bshara, Saeed" <saeedb@...zon.com>, "David S. Miller"
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-hardening@...r.kernel.org" <linux-hardening@...r.kernel.org>
Subject: RE: [PATCH v2] net: ena: replace deprecated strncpy with strscpy

> -----Original Message-----
> From: justinstitt@...gle.com <justinstitt@...gle.com>
> 
> `strncpy` is deprecated for use on NUL-terminated destination strings [1] and as
> such we should prefer more robust and less ambiguous string interfaces.
> 
> A suitable replacement is `strscpy` [2] due to the fact that it guarantees NUL-
> termination on the destination buffer without unnecessarily NUL-padding.
> 
> host_info allocation is done in ena_com_allocate_host_info() via
> dma_alloc_coherent() and is not zero initialized by alloc_etherdev_mq().
> 
> However zero initialization of the destination doesn't matter in this case,
> because strscpy() guarantees a NULL termination.
> 
> Link:
> https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-
> nul-terminated-strings [1]
> Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html
> [2]
> Link: https://github.com/KSPP/linux/issues/90
> Cc: linux-hardening@...r.kernel.org
> Signed-off-by: Justin Stitt <justinstitt@...gle.com>
> ---
> Changes in v2:
> - update commit message, dropping inaccurate statement about allocation
>   (thanks Arthur)
> - copy/paste Arthur's explanation regarding host_info allocation into
> - rebased onto mainline
> - Link to v1: https://lore.kernel.org/r/20231005-strncpy-drivers-net-ethernet-
> amazon-ena-ena_netdev-c-v1-1-ba4879974160@...gle.com
> ---
> Note: build-tested only.
> ---
>  ..................
> Best regards,
> --
> Justin Stitt <justinstitt@...gle.com>

Thanks for making the necessary changes to the commit message Justin.
Looks good.

Acked-by: Arthur Kiyanovski <akiyano@...zon.com>