[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20231206191539.06d955f3@kernel.org>
Date: Wed, 6 Dec 2023 19:15:39 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Yunsheng Lin <linyunsheng@...wei.com>
Cc: <davem@...emloft.net>, <pabeni@...hat.com>, <netdev@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, Alexander Duyck
<alexander.duyck@...il.com>, "Michael S. Tsirkin" <mst@...hat.com>, Jason
Wang <jasowang@...hat.com>, Andrew Morton <akpm@...ux-foundation.org>, Eric
Dumazet <edumazet@...gle.com>, <kvm@...r.kernel.org>,
<virtualization@...ts.linux.dev>, <linux-mm@...ck.org>
Subject: Re: [PATCH net-next 2/6] page_frag: unify gfp bit for order 3 page
allocation
On Tue, 5 Dec 2023 19:34:40 +0800 Yunsheng Lin wrote:
> __GFP_DIRECT_RECLAIM is xor'd to avoid
> direct reclaim in skb_page_frag_refill(), but it is not
> xor'd in __page_frag_cache_refill().
xor is not the same thing as masking a bit off.
The patch itself LGTM.
Powered by blists - more mailing lists