netdev - Re: [PATCH] net:stmmac:stmmac_platform:Add snps,xpcs devicetree parsing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231208091408.071680db@device.home>
Date: Fri, 8 Dec 2023 09:14:08 +0100
From: Maxime Chevallier <maxime.chevallier@...tlin.com>
To: Jiangfeng Ma <Jiangfeng.Ma@...opsys.com>
Cc: Alexandre Torgue <alexandre.torgue@...s.st.com>, Jose Abreu
 <Jose.Abreu@...opsys.com>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo
 Abeni <pabeni@...hat.com>, Maxime Coquelin <mcoquelin.stm32@...il.com>,
 Simon Horman <horms@...nel.org>, Andrew Halaney <ahalaney@...hat.com>,
 Bartosz Golaszewski <bartosz.golaszewski@...aro.org>, Shenwei Wang
 <shenwei.wang@....com>, Johannes Zink <j.zink@...gutronix.de>, "Russell
 King  (Oracle" <rmk+kernel@...linux.org.uk>, Jochen Henneberg
 <jh@...neberg-systemdesign.com>, "open list:STMMAC ETHERNET DRIVER"
 <netdev@...r.kernel.org>, "moderated  list:ARM/STM32 ARCHITECTURE"
 <linux-stm32@...md-mailman.stormreply.com>, "moderated list:ARM/STM32
 ARCHITECTURE" <linux-arm-kernel@...ts.infradead.org>, open list
 <linux-kernel@...r.kernel.org>, James Li <James.Li1@...opsys.com>, Martin
 McKenny <Martin.McKenny@...opsys.com>
Subject: Re: [PATCH] net:stmmac:stmmac_platform:Add snps,xpcs devicetree
 parsing

Hello,

On Fri, 8 Dec 2023 07:02:19 +0000
Jiangfeng Ma <Jiangfeng.Ma@...opsys.com> wrote:

> In order to setup xpcs, has_xpcs must be set to a non-zero value.
> Add new optional devicetree properties representing this.
> 
> If has_xpcs is set to true, then xpcs_an_inband should preferably be
> consistent with it, Otherwise, some errors may occur when starting
> the network, For example, the phy interface that xpcs already supports,
> but link up fails.

Can you elaborate on why you need this, and on which platform
especially ? Usually drivers for the various stmmac variants know if
they have XPCS or not, or can guess it based on some info such as the
configured PHY mode (dwmac-intel).

Besides that, there are a few issues with your submission. If DT is the
way to go (and I don't say it is), you would also need to update the
bindings to document that property.

> The types of has_xpcs and xpcs_an_inband are unsigned int,
> and generally used as flags. So it may be more reasonable to set them to
> bool type. This can also be confirmed from the type of @ovr_an_inband.

And this part would go into a separate patch.

Thanks,

Maxime