netdev - Re: [PATCH net-next v9 2/4] rust: net::phy add module_phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72=-xz42yNkjujqvpWd+xM5uetVSDXrRtSFbYXEOawXqFQ@mail.gmail.com>
Date: Fri, 8 Dec 2023 15:42:43 +0100
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: FUJITA Tomonori <fujita.tomonori@...il.com>
Cc: jarkko@...nel.org, netdev@...r.kernel.org, rust-for-linux@...r.kernel.org, 
	andrew@...n.ch, tmgross@...ch.edu, benno.lossin@...ton.me, wedsonaf@...il.com, 
	aliceryhl@...gle.com, boqun.feng@...il.com
Subject: Re: [PATCH net-next v9 2/4] rust: net::phy add module_phy_driver macro

On Tue, Dec 5, 2023 at 4:44 AM FUJITA Tomonori
<fujita.tomonori@...il.com> wrote:
>
> I follow Rust comment style here. Maybe I should do:
>
> s/This creates/This macro creates/

I think "Creates..." is fine, it is what we do in other files for functions.

> Likely `kernel::` part would be changed in the future.

Similarly, you could say "Corresponds...".

Cheers,
Miguel