netdev - Re: [PATCH net-next 2/2] ipv6: annotate data-races around np->ucast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <61832830-e4a8-4058-8cfb-2c088845a9cf@kernel.org>
Date: Fri, 8 Dec 2023 09:08:15 -0700
From: David Ahern <dsahern@...nel.org>
To: Eric Dumazet <edumazet@...gle.com>, "David S . Miller"
 <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH net-next 2/2] ipv6: annotate data-races around
 np->ucast_oif

On 12/8/23 3:12 AM, Eric Dumazet wrote:
> np->ucast_oif is read locklessly in some contexts.
> 
> Make all accesses to this field lockless, adding appropriate
> annotations.
> 
> This also makes setsockopt( IPV6_UNICAST_IF ) lockless.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> ---
>  net/ipv6/datagram.c      |  2 +-
>  net/ipv6/icmp.c          |  4 +--
>  net/ipv6/ipv6_sockglue.c | 58 ++++++++++++++++++----------------------
>  net/ipv6/ping.c          |  4 +--
>  net/ipv6/raw.c           |  2 +-
>  net/ipv6/udp.c           |  2 +-
>  net/l2tp/l2tp_ip6.c      |  2 +-
>  7 files changed, 34 insertions(+), 40 deletions(-)
> 

Reviewed-by: David Ahern <dsahern@...nel.org>