netdev - Re: [PATCH net-next 4/7] net: dsa: realtek: create realtek-common

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJq09z7Xqxs0RFHh5TWG2EvxcAgm2Ot1X-_xkjbJ7EG4_dhf+g@mail.gmail.com>
Date: Fri, 8 Dec 2023 02:01:02 -0300
From: Luiz Angelo Daros de Luca <luizluca@...il.com>
To: linus.walleij@...aro.org
Cc: alsi@...g-olufsen.dk, andrew@...n.ch, f.fainelli@...il.com, 
	olteanv@...il.com, davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, 
	pabeni@...hat.com, arinc.unal@...nc9.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 4/7] net: dsa: realtek: create realtek-common

> Some code can be shared between both interface modules (MDIO and SMI)
> and among variants. Currently, these interface functions are shared:
>
> - realtek_common_lock
> - realtek_common_unlock
> - realtek_common_probe
> - realtek_common_remove
>
> The reset during probe was moved to the last moment before a variant
> detects the switch. This way, we avoid a reset if anything else fails.
>
> Signed-off-by: Luiz Angelo Daros de Luca <luizluca@...il.com>
> Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Linus, I think I should not have kept your Reviewed-by as there are
changes like moving the match table out of the common module and
splitting the probe into pre/post.

Regards,

Luiz