netdev - STMMAC Ethernet Driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date: Fri, 8 Dec 2023 14:03:25 +0800
From: Richard Tresidder <rtresidd@...ctromag.com.au>
To: netdev@...r.kernel.org
Subject: STMMAC Ethernet Driver support

Hi
    I'm having a problem when checksum offloading in transmit is enabled.
The Mac is in an Altera Cyclone V SOC.
compatible = "altr,socfpga-stmmac", "snps,dwmac-3.70a", "snps,dwmac";

Previous working revision was a 6.3.3 based kernel.
Current testing version is a 6.6.3 LongTerm branch.
None of our patches touch anything in network, just a few custom drivers 
for HDL built in the FPGA.

The 6.3.3 iteration of the STMMAC worked fine out of the box.
And appears to be using Checksum Offload in TX according to the dma_cap 
dump from debugfs.

For the 6.6.3 based driver I was seeing bad CRC's on any tcp data 
transmitted from the MAC, icmp was fine.

I manually disabled the tx_coe cap by setting:
dma_cap->tx_coe = 0;
in dwmac1000_dma.c at about line 258 in lieu of (hw_cap & 
DMA_HW_FEAT_TXCOESEL) >> 16;

This got the interface working.

I've looked through the diffset 6.3.3 >>> 6.6.3 on the driver
drivers\net\ethernet\stmicro\stmmac
But nothing is jumping out at me.

I could use a pointer as to where to look to start tracing this.

Cheers
    Richard Tresidder