netdev - Re: [PATCH net-next] i40e: remove fake support of rx-frames-irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL+tcoAsC6s9DgsY+1_1R-Ut9AQz9rSzY0==774Gr9URZR9LKw@mail.gmail.com>
Date: Sat, 9 Dec 2023 17:07:35 +0800
From: Jason Xing <kerneljasonxing@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Tony Nguyen <anthony.l.nguyen@...el.com>, davem@...emloft.net, pabeni@...hat.com, 
	edumazet@...gle.com, netdev@...r.kernel.org, 
	Jason Xing <kernelxing@...cent.com>, 
	Pucha Himasekhar Reddy <himasekharx.reddy.pucha@...el.com>
Subject: Re: [PATCH net-next] i40e: remove fake support of rx-frames-irq

On Sat, Dec 9, 2023 at 9:20 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Thu,  7 Dec 2023 10:36:47 -0800 Tony Nguyen wrote:
> > From: Jason Xing <kernelxing@...cent.com>
> >
> > Since we never support this feature for I40E driver, we don't have to
> > display the value when using 'ethtool -c eth0'.
> >
> > Before this patch applied, the rx-frames-irq is 256 which is consistent
> > with tx-frames-irq. Apparently it could mislead users.
>
[...]
> IIUC now the rx-frames-irq will be 0 / not set, so you should also:
>
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
> index a0b10230268d..611996a35943 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
> @@ -5786,7 +5786,7 @@ static const struct ethtool_ops i40e_ethtool_recovery_mode_ops = {
>
>  static const struct ethtool_ops i40e_ethtool_ops = {
>         .supported_coalesce_params = ETHTOOL_COALESCE_USECS |
> -                                    ETHTOOL_COALESCE_MAX_FRAMES_IRQ |
> +                                    ETHTOOL_COALESCE_TX_MAX_FRAMES_IRQ |
>                                      ETHTOOL_COALESCE_USE_ADAPTIVE |
>                                      ETHTOOL_COALESCE_RX_USECS_HIGH |
>                                      ETHTOOL_COALESCE_TX_USECS_HIGH,
> --

Thanks for the review, I will add this part into my V2 patch.

Jason

> pw-bot: cr
>