netdev - Re: [PATCH net v3] octeon_ep: explicitly test for firmware ready value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231210111820.GE5817@kernel.org>
Date: Sun, 10 Dec 2023 11:18:20 +0000
From: Simon Horman <horms@...nel.org>
To: Shinas Rasheed <srasheed@...vell.com>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, hgani@...vell.com,
	vimleshk@...vell.com, egallen@...hat.com, mschmidt@...hat.com,
	pabeni@...hat.com, kuba@...nel.org, davem@...emloft.net,
	wizhao@...hat.com, konguyen@...hat.com,
	Veerasenareddy Burru <vburru@...vell.com>,
	Sathesh Edara <sedara@...vell.com>,
	Eric Dumazet <edumazet@...gle.com>,
	Abhijit Ayarekar <aayarekar@...vell.com>,
	Satananda Burla <sburla@...vell.com>
Subject: Re: [PATCH net v3] octeon_ep: explicitly test for firmware ready
 value

On Thu, Dec 07, 2023 at 09:56:46PM -0800, Shinas Rasheed wrote:
> The firmware ready value is 1, and get firmware ready status
> function should explicitly test for that value. The firmware
> ready value read will be 2 after driver load, and on unbind
> till firmware rewrites the firmware ready back to 0, the value
> seen by driver will be 2, which should be regarded as not ready.
> 
> Fixes: 10c073e40469 ("octeon_ep: defer probe if firmware not ready")
> Signed-off-by: Shinas Rasheed <srasheed@...vell.com>

Reviewed-by: Simon Horman <horms@...nel.org>